diff options
| author | Sanjay Patel <spatel@rotateright.com> | 2017-05-16 16:30:46 +0000 |
|---|---|---|
| committer | Sanjay Patel <spatel@rotateright.com> | 2017-05-16 16:30:46 +0000 |
| commit | f5eeb35dcec4c1b5cc51e140288dba1c821d89a7 (patch) | |
| tree | e7bcaaa3490ee18a5f1dd82fc9681c7729f79d2a /lldb/packages/Python/lldbsuite/support/gmodules.py | |
| parent | b10860788f9b2b8612cec4ab0768e10b960ffcf3 (diff) | |
| download | bcm5719-llvm-f5eeb35dcec4c1b5cc51e140288dba1c821d89a7.tar.gz bcm5719-llvm-f5eeb35dcec4c1b5cc51e140288dba1c821d89a7.zip | |
[InstCombine] add motivational comment for tests; NFC
The referenced tests are derived from:
https://bugs.llvm.org/show_bug.cgi?id=32791
and:
https://reviews.llvm.org/D33172
The motivation for including negative tests may not be clear, so I'm adding an explanatory comment here.
In the post-commit thread for r303133:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170515/453793.html
...it was mentioned that we don't want to add redundant tests. This is a valid point. But in this case,
we have a patch under review (D33172) that demonstrates that no existing regression tests are affected by
a proposed code change, but these are. Therefore, I think these tests have value not visible in any
existing regression tests regardless of whether they show a transform.
Differential Revision: https://reviews.llvm.org/D33242
llvm-svn: 303185
Diffstat (limited to 'lldb/packages/Python/lldbsuite/support/gmodules.py')
0 files changed, 0 insertions, 0 deletions
