diff options
| author | Ewan Crawford <ewan@codeplay.com> | 2016-02-19 17:55:10 +0000 |
|---|---|---|
| committer | Ewan Crawford <ewan@codeplay.com> | 2016-02-19 17:55:10 +0000 |
| commit | 615a807ee835bc18478770161ab8409eea2fccdc (patch) | |
| tree | a52768afc7828e7ec83166ef04ff4e4959005a21 /lldb/packages/Python/lldbsuite/support/fs.py | |
| parent | f56aeef645a1fc798e677c0ff4fd2b349e068e9f (diff) | |
| download | bcm5719-llvm-615a807ee835bc18478770161ab8409eea2fccdc.tar.gz bcm5719-llvm-615a807ee835bc18478770161ab8409eea2fccdc.zip | |
refactor/cleanup ClangExpressionParser::Parse
This patches does the following:
+ fix return type: ClangExpressionParser::Parse returns unsigned, but was actually returning a signed value, num_errors.
+ use helper clang::TextDiagnosticBuffer::getNumErrors() instead of counting the errors ourself.
+ limit scoping of block-level automatic variables as much as practical.
+ remove reused multipurpose TextDiagnosticBuffer::const_iterator in favour of loop-scoped err, warn, and note variables in the diagnostic printing code.
+ refactor diagnostic printing loops to use a proper loop invariant.
Author: Luke Drummond <luke.drummond@codeplay.com>
Differential Revision: http://reviews.llvm.org/D17273
llvm-svn: 261345
Diffstat (limited to 'lldb/packages/Python/lldbsuite/support/fs.py')
0 files changed, 0 insertions, 0 deletions
