diff options
author | Rui Ueyama <ruiu@google.com> | 2014-04-18 19:59:33 +0000 |
---|---|---|
committer | Rui Ueyama <ruiu@google.com> | 2014-04-18 19:59:33 +0000 |
commit | a2b0334e939fd8ce92cc45c93d0cef3fb9715f6a (patch) | |
tree | 79c41e9ebeb75e8e7cf989b95b4731fc7bbbfc8c /lld | |
parent | bb094f0669dd8a8c55f6cb291513af6e447dc7d5 (diff) | |
download | bcm5719-llvm-a2b0334e939fd8ce92cc45c93d0cef3fb9715f6a.tar.gz bcm5719-llvm-a2b0334e939fd8ce92cc45c93d0cef3fb9715f6a.zip |
Use switch for readability.
llvm-svn: 206638
Diffstat (limited to 'lld')
-rw-r--r-- | lld/lib/Driver/WinLinkModuleDef.cpp | 27 |
1 files changed, 15 insertions, 12 deletions
diff --git a/lld/lib/Driver/WinLinkModuleDef.cpp b/lld/lib/Driver/WinLinkModuleDef.cpp index 0932b88c9c2..b87cf1b91be 100644 --- a/lld/lib/Driver/WinLinkModuleDef.cpp +++ b/lld/lib/Driver/WinLinkModuleDef.cpp @@ -105,8 +105,9 @@ void Parser::error(const Token &tok, Twine msg) { llvm::Optional<Directive *> Parser::parse() { consumeToken(); - // EXPORTS - if (_tok._kind == Kind::kw_exports) { + switch (_tok._kind) { + case Kind::kw_exports: { + // EXPORTS std::vector<PECOFFLinkingContext::ExportDesc> exports; for (;;) { PECOFFLinkingContext::ExportDesc desc; @@ -116,37 +117,39 @@ llvm::Optional<Directive *> Parser::parse() { } return new (_alloc) Exports(exports); } - // HEAPSIZE - if (_tok._kind == Kind::kw_heapsize) { + case Kind::kw_heapsize: { + // HEAPSIZE uint64_t reserve, commit; if (!parseMemorySize(reserve, commit)) return llvm::None; return new (_alloc) Heapsize(reserve, commit); } - // STACKSIZE - if (_tok._kind == Kind::kw_stacksize) { + case Kind::kw_stacksize: { + // STACKSIZE uint64_t reserve, commit; if (!parseMemorySize(reserve, commit)) return llvm::None; return new (_alloc) Stacksize(reserve, commit); } - // NAME - if (_tok._kind == Kind::kw_name) { + case Kind::kw_name: { + // NAME std::string outputPath; uint64_t baseaddr; if (!parseName(outputPath, baseaddr)) return llvm::None; return new (_alloc) Name(outputPath, baseaddr); } - // VERSION - if (_tok._kind == Kind::kw_version) { + case Kind::kw_version: { + // VERSION int major, minor; if (!parseVersion(major, minor)) return llvm::None; return new (_alloc) Version(major, minor); } - error(_tok, Twine("Unknown directive: ") + _tok._range); - return llvm::None; + default: + error(_tok, Twine("Unknown directive: ") + _tok._range); + return llvm::None; + } } bool Parser::parseExport(PECOFFLinkingContext::ExportDesc &result) { |