Revert "[WebAssembly] Error on mismatched function signature in final output"

This caused a lot of issues on the WebAssembly waterfall.
In particular, until with the signature of `main`.  We
probably want a better solution for main before we re-land.

Reverts rL335192

llvm-svn: 335355

1 files changed, 5 insertions, 20 deletions

diff --git a/lld/wasm/SymbolTable.cpp b/lld/wasm/SymbolTable.cpp
index 77b2f18c286..1180cfc6759 100644
--- a/lld/wasm/SymbolTable.cpp
+++ b/lld/wasm/SymbolTable.cpp
@@ -106,7 +106,7 @@ static void reportTypeError(const Symbol *Existing, const InputFile *File,
         " in " + toString(File));
 }
 
-static void checkFunctionType(Symbol *Existing, const InputFile *File,
+static void checkFunctionType(const Symbol *Existing, const InputFile *File,
                               const WasmSignature *NewSig) {
   auto ExistingFunction = dyn_cast<FunctionSymbol>(Existing);
   if (!ExistingFunction) {
@@ -114,27 +114,12 @@ static void checkFunctionType(Symbol *Existing, const InputFile *File,
     return;
   }
 
-
   const WasmSignature *OldSig = ExistingFunction->getFunctionType();
   if (OldSig && NewSig && *NewSig != *OldSig) {
-    // Don't generate more than one warning per symbol.
-    if (Existing->SignatureMismatch)
-      return;
-    Existing->SignatureMismatch = true;
-
-    std::string msg = ("function signature mismatch: " + Existing->getName() +
-                       "\n>>> defined as " + toString(*OldSig) + " in " +
-                       toString(Existing->getFile()) + "\n>>> defined as " +
-                       toString(*NewSig) + " in " + toString(File))
-                          .str();
-    // A function signature mismatch is only really problem if the mismatched
-    // symbol is included in the final output, and gc-sections can remove the
-    // offending uses.  Therefore we delay reporting this as an error when
-    // section GC is enabled.
-    if (Config->GcSections)
-      warn(msg);
-    else
-      error(msg);
+    warn("function signature mismatch: " + Existing->getName() +
+         "\n>>> defined as " + toString(*OldSig) + " in " +
+         toString(Existing->getFile()) + "\n>>> defined as " +
+         toString(*NewSig) + " in " + toString(File));
   }
 }