diff options
author | Rui Ueyama <ruiu@google.com> | 2014-06-04 09:00:55 +0000 |
---|---|---|
committer | Rui Ueyama <ruiu@google.com> | 2014-06-04 09:00:55 +0000 |
commit | e5d36a910e5142f4b88c02cf2895a946b29530b1 (patch) | |
tree | 81036fb5f7e5c910acd1389c18536e912a22617a /lld/lib/ReaderWriter/FileArchive.cpp | |
parent | c0a3fa977dbb4aa2d8dc13763a211010a0221a54 (diff) | |
download | bcm5719-llvm-e5d36a910e5142f4b88c02cf2895a946b29530b1.tar.gz bcm5719-llvm-e5d36a910e5142f4b88c02cf2895a946b29530b1.zip |
Add a comment, fix style.
llvm-svn: 210174
Diffstat (limited to 'lld/lib/ReaderWriter/FileArchive.cpp')
-rw-r--r-- | lld/lib/ReaderWriter/FileArchive.cpp | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/lld/lib/ReaderWriter/FileArchive.cpp b/lld/lib/ReaderWriter/FileArchive.cpp index 140d43e7dc2..e1685fb0f62 100644 --- a/lld/lib/ReaderWriter/FileArchive.cpp +++ b/lld/lib/ReaderWriter/FileArchive.cpp @@ -120,6 +120,9 @@ protected: return error_code(); } + // Parses the given memory buffer as an object file, and returns success error + // code if the given symbol is a data symbol. If the symbol is not a data + // symbol or does not exist, returns a failure. error_code isDataSymbol(std::unique_ptr<MemoryBuffer> mb, StringRef symbol) const { auto objOrErr(ObjectFile::createObjectFile(mb.release())); if (auto ec = objOrErr.getError()) @@ -132,12 +135,9 @@ protected: StringRef symbolname; for (symbol_iterator i = ibegin; i != iend; ++i) { - error_code ec; - // Get symbol name - if ((ec = (i->getName(symbolname)))) + if (error_code ec = i->getName(symbolname)) return ec; - if (symbolname != symbol) continue; @@ -148,12 +148,11 @@ protected: continue; // Get Symbol Type - if ((ec = (i->getType(symtype)))) + if (error_code ec = i->getType(symtype)) return ec; - if (symtype == SymbolRef::ST_Data) { + if (symtype == SymbolRef::ST_Data) return error_code(); - } } return object_error::parse_failed; } |