Rename warnUnorderableSymbol maybeWarnUnorderableSymbol because the function doesn't always emit a warning.

llvm-svn: 345393

4 files changed, 4 insertions, 4 deletions

diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index 929adacb221..17f15d8e016 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -662,8 +662,8 @@ static void readCallGraph(MemoryBufferRef MB) {
         warn(MB.getBufferIdentifier() + ": no such symbol: " + Name);
       return nullptr;
     }
+    maybeWarnUnorderableSymbol(Sym);
 
-    warnUnorderableSymbol(Sym);
     if (Defined *DR = dyn_cast_or_null<Defined>(Sym))
       return dyn_cast_or_null<InputSectionBase>(DR->Section);
     return nullptr;
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 9073d21eab7..5f7d95381b4 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -260,7 +260,7 @@ void elf::printTraceSymbol(Symbol *Sym) {
   message(toString(Sym->File) + S + Sym->getName());
 }
 
-void elf::warnUnorderableSymbol(const Symbol *Sym) {
+void elf::maybeWarnUnorderableSymbol(const Symbol *Sym) {
   if (!Config->WarnSymbolOrdering)
     return;
 
diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 7a9fbe4c6ff..a6c5697a697 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -405,7 +405,7 @@ void replaceSymbol(Symbol *S, ArgT &&... Arg) {
     printTraceSymbol(S);
 }
 
-void warnUnorderableSymbol(const Symbol *Sym);
+void maybeWarnUnorderableSymbol(const Symbol *Sym);
 } // namespace elf
 } // namespace lld
 
diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index cd3f0806c3d..e486a77e7c5 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -1105,7 +1105,7 @@ static DenseMap<const InputSectionBase *, int> buildSectionOrder() {
     SymbolOrderEntry &Ent = It->second;
     Ent.Present = true;
 
-    warnUnorderableSymbol(&Sym);
+    maybeWarnUnorderableSymbol(&Sym);
 
     if (auto *D = dyn_cast<Defined>(&Sym)) {
       if (auto *Sec = dyn_cast_or_null<InputSectionBase>(D->Section)) {