diff options
| author | Petr Hosek <phosek@chromium.org> | 2017-05-30 03:18:28 +0000 |
|---|---|---|
| committer | Petr Hosek <phosek@chromium.org> | 2017-05-30 03:18:28 +0000 |
| commit | 3c6de1a66caff299f52d393c8eb4d677d2158dc8 (patch) | |
| tree | 6f037359209824c7aaba9c6bdb4a3b2a155225b5 /lld/ELF/LinkerScript.cpp | |
| parent | 057084180662c897a94563768b374f8b58e71ebf (diff) | |
| download | bcm5719-llvm-3c6de1a66caff299f52d393c8eb4d677d2158dc8.tar.gz bcm5719-llvm-3c6de1a66caff299f52d393c8eb4d677d2158dc8.zip | |
[ELF] Use late evaluation for ALIGN in expression
While the following expression is handled fine:
PROVIDE_HIDDEN(newsym = oldsym + address);
The following expression triggers an error because the expression
is evaluated as absolute:
PROVIDE_HIDDEN(newsym = ALIGN(oldsym, CONSTANT(MAXPAGESIZE)) + address);
To avoid this error, we use late evaluation for ALIGN by making the
alignment an attribute of the expression itself.
Differential Revision: https://reviews.llvm.org/D33629
llvm-svn: 304185
Diffstat (limited to 'lld/ELF/LinkerScript.cpp')
| -rw-r--r-- | lld/ELF/LinkerScript.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp index 492b81c1fa7..0feb830b797 100644 --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -52,11 +52,12 @@ LinkerScript *elf::Script; uint64_t ExprValue::getValue() const { if (Sec) { if (Sec->getOutputSection()) - return Sec->getOffset(Val) + Sec->getOutputSection()->Addr; + return alignTo(Sec->getOffset(Val) + Sec->getOutputSection()->Addr, + Alignment); error("unable to evaluate expression: input section " + Sec->Name + " has no output section assigned"); } - return Val; + return alignTo(Val, Alignment); } uint64_t ExprValue::getSecAddr() const { @@ -143,7 +144,7 @@ void LinkerScript::assignSymbol(SymbolAssignment *Cmd, bool InSec) { } else { Sym->Section = V.Sec; if (Sym->Section->Flags & SHF_ALLOC) - Sym->Value = V.Val; + Sym->Value = alignTo(V.Val, V.Alignment); else Sym->Value = V.getValue(); } |

