diff options
| author | Eric Fiselier <eric@efcs.ca> | 2019-03-05 02:10:31 +0000 |
|---|---|---|
| committer | Eric Fiselier <eric@efcs.ca> | 2019-03-05 02:10:31 +0000 |
| commit | 1c014d75b4cdcfab5cef304e5f9c5def96468751 (patch) | |
| tree | 5be06a180e101fba1baa66173ee9bd60b254db47 /libcxx/utils | |
| parent | e69290dc7ff7319acf5904f15ab6630fad07ab58 (diff) | |
| download | bcm5719-llvm-1c014d75b4cdcfab5cef304e5f9c5def96468751.tar.gz bcm5719-llvm-1c014d75b4cdcfab5cef304e5f9c5def96468751.zip | |
Fix -fsanitize=vptr badness in <__debug>
Summary:
This patch fixes a lifetime bug when inserting a new container into the debug database. It is
diagnosed by UBSAN when debug mode is enabled. This patch corrects how nodes are constructed
during insertion.
The fix requires unconditionally breaking the debug mode ABI. Users should not expect ABI
stability from debug mode.
Reviewers: ldionne, serge-sans-paille, EricWF
Reviewed By: EricWF
Subscribers: mclow.lists, christof, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D58011
llvm-svn: 355367
Diffstat (limited to 'libcxx/utils')
| -rw-r--r-- | libcxx/utils/libcxx/test/config.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py index c619086b61d..6daf356ef9f 100644 --- a/libcxx/utils/libcxx/test/config.py +++ b/libcxx/utils/libcxx/test/config.py @@ -939,7 +939,7 @@ class Configuration(object): def add_ubsan(): self.cxx.flags += ['-fsanitize=undefined', - '-fno-sanitize=vptr,function,float-divide-by-zero', + '-fno-sanitize=float-divide-by-zero', '-fno-sanitize-recover=all'] self.exec_env['UBSAN_OPTIONS'] = 'print_stacktrace=1' self.config.available_features.add('ubsan') |
