diff options
author | Michael Park <mpark@apache.org> | 2017-03-01 01:07:56 +0000 |
---|---|---|
committer | Michael Park <mpark@apache.org> | 2017-03-01 01:07:56 +0000 |
commit | 466f0653a31817b6201c6e01d49e6e7f76b98cfb (patch) | |
tree | 4dbd2ddc3c192d737a2208005c4740ebba0dcfa4 /libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp | |
parent | 1d855afc5fceaf63b73182b841fc0d47ebfaf32d (diff) | |
download | bcm5719-llvm-466f0653a31817b6201c6e01d49e6e7f76b98cfb.tar.gz bcm5719-llvm-466f0653a31817b6201c6e01d49e6e7f76b98cfb.zip |
Updated the XFAIL comment in variant tests.
Summary:
`ConstexprTestTypes::NoCtors` is an aggregate type (and consequently a literal type) in C++17,
but not in C++14 since it has a base class. This patch updates the comment to accurately describe the reason for the XFAIL.
Reviewers: EricWF
Reviewed By: EricWF
Differential Revision: https://reviews.llvm.org/D30481
llvm-svn: 296558
Diffstat (limited to 'libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp')
-rw-r--r-- | libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp b/libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp index 6675b5f2b2b..a4ea592709e 100644 --- a/libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp +++ b/libcxx/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp @@ -10,7 +10,10 @@ // UNSUPPORTED: c++98, c++03, c++11, c++14 -// The following compilers don't allow constexpr variables of non-literal type. +// The following compilers don't consider a type an aggregate type (and +// consequently not a literal type) if it has a base class at all. +// In C++17, an aggregate type is allowed to have a base class if it's not +// virtual, private, nor protected (e.g. ConstexprTestTypes:::NoCtors). // XFAIL: gcc-5, gcc-6 // XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8 // XFAIL: apple-clang-6, apple-clang-7, apple-clang-8 |