summaryrefslogtreecommitdiffstats
path: root/libcxx/test/std/utilities/tuple
diff options
context:
space:
mode:
authorStephan T. Lavavej <stl@exchange.microsoft.com>2017-12-13 00:51:27 +0000
committerStephan T. Lavavej <stl@exchange.microsoft.com>2017-12-13 00:51:27 +0000
commit79e0733c20ea7dafd270aa468640c6cd5063b13c (patch)
tree0613c8f4165935dd6c62fd4f78039bb5b96155ce /libcxx/test/std/utilities/tuple
parent1d3d8adad7d77e92e523fa736fd23ce587ead91d (diff)
downloadbcm5719-llvm-79e0733c20ea7dafd270aa468640c6cd5063b13c.tar.gz
bcm5719-llvm-79e0733c20ea7dafd270aa468640c6cd5063b13c.zip
[libcxx] [test] Fix MSVC warnings, null pointer deref.
test/std/algorithms/alg.modifying.operations/alg.generate/generate_n.pass.cpp Silence MSVC warning C4244. This is expected when passing floating-point values for size. test/std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp test/std/utilities/template.bitset/bitset.members/to_ulong.pass.cpp Avoid MSVC "warning C4293: '<<': shift count negative or too big, undefined behavior". MSVC sees (1ULL << N) and warns - being guarded by const bool canFit is insufficient. A small change to the code avoids the warning without the need for a pragma. Remove a spurious printf() declaration from to_ullong.pass.cpp. Change ULL to UL in to_ulong.pass.cpp. The ULL suffix was probably copy-pasted. test/std/utilities/tuple/tuple.general/ignore.pass.cpp Use LIBCPP_STATIC_ASSERT for consistency with other files. test/support/container_test_types.h Fix a null pointer dereference, found by MSVC /analyze warning C6011 "Dereferencing NULL pointer 'm_expected_args'." Fixes D41030. llvm-svn: 320535
Diffstat (limited to 'libcxx/test/std/utilities/tuple')
-rw-r--r--libcxx/test/std/utilities/tuple/tuple.general/ignore.pass.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/libcxx/test/std/utilities/tuple/tuple.general/ignore.pass.cpp b/libcxx/test/std/utilities/tuple/tuple.general/ignore.pass.cpp
index 8dae3a5dcb0..a7a0904cf49 100644
--- a/libcxx/test/std/utilities/tuple/tuple.general/ignore.pass.cpp
+++ b/libcxx/test/std/utilities/tuple/tuple.general/ignore.pass.cpp
@@ -48,9 +48,7 @@ int main() {
{
static_assert(test_ignore_constexpr(), "");
}
-#if defined(_LIBCPP_VERSION)
{
- static_assert(std::is_trivial<decltype(std::ignore)>::value, "");
+ LIBCPP_STATIC_ASSERT(std::is_trivial<decltype(std::ignore)>::value, "");
}
-#endif
}
OpenPOWER on IntegriCloud