diff options
author | Eric Fiselier <eric@efcs.ca> | 2017-05-10 19:35:49 +0000 |
---|---|---|
committer | Eric Fiselier <eric@efcs.ca> | 2017-05-10 19:35:49 +0000 |
commit | f09df7723636fb0cbd7cda44f79dae5abb917566 (patch) | |
tree | f89d95ac225f274af5778e54c2e3dfdc10751b54 /libcxx/test/std/strings/string.conversions/stof.pass.cpp | |
parent | d7dc225888b7f6925099cdb0fe4da77a62dd74d4 (diff) | |
download | bcm5719-llvm-f09df7723636fb0cbd7cda44f79dae5abb917566.tar.gz bcm5719-llvm-f09df7723636fb0cbd7cda44f79dae5abb917566.zip |
[libc++] Fix PR32979 - types with a private std::enable_shared_from_this base break shared_ptr
Summary:
This patch fixes bugs.llvm.org/PR32979.
[util.smartptr.shared.const] says:
> In the constructor definitions below, enables shared_from_this with p, for a pointer p of type Y*, means
> that if Y has an unambiguous and accessible base class that is a specialization of enable_shared_from_-
> this.
This means that libc++ needs to respect the access specifier of the base class, and not attempt to construct
and enabled_shared_from_this base if it is private. However access specifiers don't affect overload resolution
so our current implementation will attempt to construct the private base.
This patch uses SFINAE to correctly detect if the shared_ptr input has an accessible enable_shared_from_this
base class.
Reviewers: mclow.lists
Reviewed By: mclow.lists
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D33033
llvm-svn: 302709
Diffstat (limited to 'libcxx/test/std/strings/string.conversions/stof.pass.cpp')
0 files changed, 0 insertions, 0 deletions