summaryrefslogtreecommitdiffstats
path: root/libcxx/test/std/strings/basic.string/string.ops/string_compare
diff options
context:
space:
mode:
authorMatthias Braun <matze@braunis.de>2016-07-21 03:50:39 +0000
committerMatthias Braun <matze@braunis.de>2016-07-21 03:50:39 +0000
commitd9fdad72aefb6e152a1505807e5afad3a6d7e57b (patch)
treee2cb1fdc5b6d300e933175dedad172ee57f0c780 /libcxx/test/std/strings/basic.string/string.ops/string_compare
parente3fc4d0fdda3762fc0e88bb426274d8fc946e480 (diff)
downloadbcm5719-llvm-d9fdad72aefb6e152a1505807e5afad3a6d7e57b.tar.gz
bcm5719-llvm-d9fdad72aefb6e152a1505807e5afad3a6d7e57b.zip
IPRA: Fix RegMask calculation for alias registers
This patch fixes a very subtle bug in regmask calculation. Thanks to zan jyu Wong <zyfwong@gmail.com> for bringing this to notice. For example if CL is only clobbered than CH should not be marked clobbered but CX, RCX and ECX should be mark clobbered. Previously for each modified register all of its aliases are marked clobbered by markRegClobbred() in RegUsageInfoCollector.cpp but that is wrong because when CL is clobbered then MRI::isPhysRegModified() will return true for CL, CX, ECX, RCX which is correct behavior but then for CX, EXC, RCX we mark CH also clobbered as CH is aliased to CX,ECX,RCX so markRegClobbred() is not required because isPhysRegModified already take cares of proper aliasing register. A very simple test case has been added to verify this change. Please find relevant bug report here : http://llvm.org/PR28567 Patch by Vivek Pandya <vivekvpandya@gmail.com> Differential Revision: https://reviews.llvm.org/D22400 llvm-svn: 276235
Diffstat (limited to 'libcxx/test/std/strings/basic.string/string.ops/string_compare')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud