diff options
author | Louis Dionne <ldionne@apple.com> | 2018-10-25 12:13:43 +0000 |
---|---|---|
committer | Louis Dionne <ldionne@apple.com> | 2018-10-25 12:13:43 +0000 |
commit | 9b3222f6134f40b68e16faf694ed9e97bc9fd325 (patch) | |
tree | 701f6ead66e1873d6cbab03cf2d4917c61417822 /libcxx/include/__debug | |
parent | 77c26aebdaae0196fc131eb3b613dac3b0023814 (diff) | |
download | bcm5719-llvm-9b3222f6134f40b68e16faf694ed9e97bc9fd325.tar.gz bcm5719-llvm-9b3222f6134f40b68e16faf694ed9e97bc9fd325.zip |
[libc++] Make sure we can build libc++ with -fvisibility=hidden
Summary:
When building with -fvisibility=hidden, some symbols do not get exported from
libc++.dylib. This means that some entities are not explicitly given default
visibility in the source code, and that we rely on the fact -fvisibility=default
is the default. This commit explicitly gives default visibility to those
symbols to avoid being dependent on the command line flags used.
The commit also remove symbols from the dylib -- those symbols do not
actually need to be exported from the dylib and this should not be an
ABI break.
Finally, in the future, we may want to mark the whole std:: namespace as
having hidden visibility (to switch from opt-out to opt-in), in which
case the changes done in this commit will be required.
Reviewers: EricWF
Subscribers: mgorny, christof, dexonsmith, libcxx-commits
Differential Revision: https://reviews.llvm.org/D52662
llvm-svn: 345260
Diffstat (limited to 'libcxx/include/__debug')
-rw-r--r-- | libcxx/include/__debug | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libcxx/include/__debug b/libcxx/include/__debug index d01bacdf7ed..a8788f68f8f 100644 --- a/libcxx/include/__debug +++ b/libcxx/include/__debug @@ -74,7 +74,7 @@ typedef void(*__libcpp_debug_function_type)(__libcpp_debug_info const&); /// __libcpp_debug_function - The handler function called when a _LIBCPP_ASSERT /// fails. -extern _LIBCPP_EXTERN_VIS __libcpp_debug_function_type __libcpp_debug_function; +extern _LIBCPP_EXPORTED_FROM_ABI __libcpp_debug_function_type __libcpp_debug_function; /// __libcpp_abort_debug_function - A debug handler that aborts when called. _LIBCPP_NORETURN _LIBCPP_FUNC_VIS |