diff options
author | Louis Dionne <ldionne@apple.com> | 2018-07-05 18:41:50 +0000 |
---|---|---|
committer | Louis Dionne <ldionne@apple.com> | 2018-07-05 18:41:50 +0000 |
commit | 195a499d638db5157a64c9c816b76154096ecd52 (patch) | |
tree | cc8b828d9c2b9f596d7ee41600d0c59efcad2867 /libcxx/docs/DesignDocs | |
parent | d8f5b2d612d2d612e9d0503752c00b43ed8f4ba7 (diff) | |
download | bcm5719-llvm-195a499d638db5157a64c9c816b76154096ecd52.tar.gz bcm5719-llvm-195a499d638db5157a64c9c816b76154096ecd52.zip |
Revert "[libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY"
This reverts commit r336369. The commit had two problems:
1. __pbump was marked as _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY instead of
_LIBCPP_INLINE_VISIBILITY, which lead to two symbols being added in the
dylib and the check-cxx-abilist failing.
2. The LLDB tests started failing because they undefine
`_LIBCPP_INLINE_VISIBILITY`. I need to figure out why they do that and
fix the tests before we can go forward with this change.
llvm-svn: 336382
Diffstat (limited to 'libcxx/docs/DesignDocs')
-rw-r--r-- | libcxx/docs/DesignDocs/VisibilityMacros.rst | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/libcxx/docs/DesignDocs/VisibilityMacros.rst b/libcxx/docs/DesignDocs/VisibilityMacros.rst index 69a09974acd..993ce2cca5f 100644 --- a/libcxx/docs/DesignDocs/VisibilityMacros.rst +++ b/libcxx/docs/DesignDocs/VisibilityMacros.rst @@ -41,10 +41,10 @@ Visibility Macros library and has an empty definition otherwise. **_LIBCPP_INLINE_VISIBILITY** - Mark a function as not being part of the ABI of any final linked image that - uses it, and also as being internal to each TU that uses that function. In - other words, the address of a function marked with this attribute is not - guaranteed to be the same across translation units. + Mark a function as hidden and force inlining whenever possible. + +**_LIBCPP_ALWAYS_INLINE** + A synonym for `_LIBCPP_INLINE_VISIBILITY` **_LIBCPP_TYPE_VIS** Mark a type's typeinfo, vtable and members as having default visibility. |