diff options
| author | Petr Hosek <phosek@chromium.org> | 2019-01-30 23:18:05 +0000 |
|---|---|---|
| committer | Petr Hosek <phosek@chromium.org> | 2019-01-30 23:18:05 +0000 |
| commit | 8e7891544642c1326737c92be68edd1c90e7a660 (patch) | |
| tree | 414e3e58d4c6cc4e987d341ce93ecb76906a138f /libcxx/benchmarks | |
| parent | 1f7eda5aac1dd9abd754044ba9883d4e81cc08c0 (diff) | |
| download | bcm5719-llvm-8e7891544642c1326737c92be68edd1c90e7a660.tar.gz bcm5719-llvm-8e7891544642c1326737c92be68edd1c90e7a660.zip | |
[CMake] Use correct visibility for linked libraries in CMake
When linking library dependencies, we shouldn't need to export linked
libraries to dependents. We should be explicit about this in
target_link_libraries, otherwise other targets that depend on these such
as sanitizers get repeated (and possibly even conflicting) dependencies.
Differential Revision: https://reviews.llvm.org/D57456
llvm-svn: 352688
Diffstat (limited to 'libcxx/benchmarks')
| -rw-r--r-- | libcxx/benchmarks/CMakeLists.txt | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libcxx/benchmarks/CMakeLists.txt b/libcxx/benchmarks/CMakeLists.txt index 3823b87b39e..637035e5c26 100644 --- a/libcxx/benchmarks/CMakeLists.txt +++ b/libcxx/benchmarks/CMakeLists.txt @@ -137,6 +137,7 @@ function(add_benchmark_test name source_file) add_executable(${libcxx_target} EXCLUDE_FROM_ALL ${source_file}) add_dependencies(${libcxx_target} cxx cxx-headers google-benchmark-libcxx) add_dependencies(cxx-benchmarks ${libcxx_target}) + target_link_libraries(${libcxx_target} ${LIBCXX_LIBRARIES}) if (LIBCXX_ENABLE_SHARED) target_link_libraries(${libcxx_target} cxx_shared) else() |
