diff options
| author | Louis Dionne <ldionne@apple.com> | 2019-10-08 14:10:55 +0000 |
|---|---|---|
| committer | Louis Dionne <ldionne@apple.com> | 2019-10-08 14:10:55 +0000 |
| commit | 534c86d172528d791738c0503948ee9bf883a9f3 (patch) | |
| tree | 76b360754cc8dc83926c260804a8c4abea68707f /libcxx/benchmarks | |
| parent | c91f1992a6cc13005550ae523aea2627e2ebd977 (diff) | |
| download | bcm5719-llvm-534c86d172528d791738c0503948ee9bf883a9f3.tar.gz bcm5719-llvm-534c86d172528d791738c0503948ee9bf883a9f3.zip | |
[libc++] Use PRIVATE to link benchmark dependencies
It's better style to use PRIVATE when linking libraries to executables,
and it doesn't make a difference since executables don't need to propagate
their link-time dependencies anyway.
llvm-svn: 374050
Diffstat (limited to 'libcxx/benchmarks')
| -rw-r--r-- | libcxx/benchmarks/CMakeLists.txt | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/libcxx/benchmarks/CMakeLists.txt b/libcxx/benchmarks/CMakeLists.txt index 56fadff1f93..efe79149853 100644 --- a/libcxx/benchmarks/CMakeLists.txt +++ b/libcxx/benchmarks/CMakeLists.txt @@ -135,16 +135,16 @@ function(add_benchmark_test name source_file) add_dependencies(${libcxx_target} cxx cxx-headers google-benchmark-libcxx) add_dependencies(cxx-benchmarks ${libcxx_target}) if (LIBCXX_ENABLE_SHARED) - target_link_libraries(${libcxx_target} cxx_shared) + target_link_libraries(${libcxx_target} PRIVATE cxx_shared) else() - target_link_libraries(${libcxx_target} cxx_static) + target_link_libraries(${libcxx_target} PRIVATE cxx_static) endif() if (TARGET cxx_experimental) - target_link_libraries(${libcxx_target} cxx_experimental) + target_link_libraries(${libcxx_target} PRIVATE cxx_experimental) endif() - target_link_libraries(${libcxx_target} -lbenchmark) + target_link_libraries(${libcxx_target} PRIVATE -lbenchmark) if (LLVM_USE_SANITIZER) - target_link_libraries(${libcxx_target} -ldl) + target_link_libraries(${libcxx_target} PRIVATE -ldl) endif() set_target_properties(${libcxx_target} PROPERTIES @@ -161,14 +161,14 @@ function(add_benchmark_test name source_file) add_executable(${native_target} EXCLUDE_FROM_ALL ${source_file}) add_dependencies(${native_target} google-benchmark-native google-benchmark-libcxx) - target_link_libraries(${native_target} -lbenchmark) + target_link_libraries(${native_target} PRIVATE -lbenchmark) if (LIBCXX_BENCHMARK_NATIVE_STDLIB STREQUAL "libstdc++") - target_link_libraries(${native_target} ${LIBSTDCXX_FILESYSTEM_LIB}) + target_link_libraries(${native_target} PRIVATE ${LIBSTDCXX_FILESYSTEM_LIB}) elseif (LIBCXX_BENCHMARK_NATIVE_STDLIB STREQUAL "libc++") - target_link_libraries(${native_target} -lc++fs -lc++experimental) + target_link_libraries(${native_target} PRIVATE -lc++fs -lc++experimental) endif() if (LIBCXX_HAS_PTHREAD_LIB) - target_link_libraries(${native_target} -pthread) + target_link_libraries(${native_target} PRIVATE -pthread) endif() add_dependencies(cxx-benchmarks ${native_target}) set_target_properties(${native_target} |
