diff options
| author | Dan Liew <dan@su-root.co.uk> | 2018-03-09 23:12:32 +0000 |
|---|---|---|
| committer | Dan Liew <dan@su-root.co.uk> | 2018-03-09 23:12:32 +0000 |
| commit | 0c51c94b0052ebb2c0427e02cb568cf47e6183c9 (patch) | |
| tree | e6bddf48549d20e5292dee27016a77d36adaac36 /compiler-rt | |
| parent | afacada94ba69f1a902253676da2557a308b464e (diff) | |
| download | bcm5719-llvm-0c51c94b0052ebb2c0427e02cb568cf47e6183c9.tar.gz bcm5719-llvm-0c51c94b0052ebb2c0427e02cb568cf47e6183c9.zip | |
[asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`
by explicitly listing where we expect this test to work.
Because this test invokes undefined behaviour all sorts of things
can happen (e.g. crash, or on some bots asan manages to catch
something). The test seems to pass okay on Darwin (x86_64/x86_64/i386)
and on Linux (x86_64/i386) so explicitly require one of these platforms
to run the test.
llvm-svn: 327185
Diffstat (limited to 'compiler-rt')
| -rw-r--r-- | compiler-rt/test/asan/TestCases/strcat-overlap.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/compiler-rt/test/asan/TestCases/strcat-overlap.cc b/compiler-rt/test/asan/TestCases/strcat-overlap.cc index fa1f72525bf..89991fbd788 100644 --- a/compiler-rt/test/asan/TestCases/strcat-overlap.cc +++ b/compiler-rt/test/asan/TestCases/strcat-overlap.cc @@ -26,7 +26,11 @@ // RUN: echo "interceptor_name:strcat" > %t.supp // RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t -// REQUIRES: (target-is-x86_64 || target-is-x86_64h) && !ios +// This test when run with suppressions invokes undefined +// behavior which can cause all sorts of bad things to happen +// depending on how strcat() is implemented. For now only run +// on platforms where we know the test passes. +// REQUIRES: x86_64h-darwin || x86_64-darwin || i386-darwin || x86_64-linux || i386-linux // UNSUPPORTED: win32 // UNSUPPORTED: android |
