diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-10-30 17:17:35 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-10-30 17:17:35 +0000 |
| commit | 3c845b6f1b821ffb4674f0404699eae0a89158c6 (patch) | |
| tree | c4f173c272aa9aae7f2b9d7eebf7aead620d6240 /compiler-rt/lib | |
| parent | 2d4e11228b40be8556659608120f657f7b58213d (diff) | |
| download | bcm5719-llvm-3c845b6f1b821ffb4674f0404699eae0a89158c6.tar.gz bcm5719-llvm-3c845b6f1b821ffb4674f0404699eae0a89158c6.zip | |
[Sanitizer] Update comment in sanitizer_symbolizer.h
llvm-svn: 193700
Diffstat (limited to 'compiler-rt/lib')
| -rw-r--r-- | compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h | 20 |
1 files changed, 7 insertions, 13 deletions
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h index fb9473f3170..f41913281cc 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h +++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h @@ -7,19 +7,14 @@ // //===----------------------------------------------------------------------===// // -// Symbolizer is intended to be used by both -// AddressSanitizer and ThreadSanitizer to symbolize a given -// address. It is an analogue of addr2line utility and allows to map -// instruction address to a location in source code at run-time. +// Symbolizer is used by sanitizers to map instruction address to a location in +// source code at run-time. Symbolizer either uses __sanitizer_symbolize_* +// defined in the program, or (if they are missing) tries to find and +// launch "llvm-symbolizer" commandline tool in a separate process and +// communicate with it. // -// Symbolizer is planned to use debug information (in DWARF format) -// in a binary via interface defined in "llvm/DebugInfo/DIContext.h" -// -// Symbolizer code should be called from the run-time library of -// dynamic tools, and generally should not call memory allocation -// routines or other system library functions intercepted by those tools. -// Instead, Symbolizer code should use their replacements, defined in -// "compiler-rt/lib/sanitizer_common/sanitizer_libc.h". +// Generally we should try to avoid calling system library functions during +// symbolization (and use their replacements from sanitizer_libc.h instead). //===----------------------------------------------------------------------===// #ifndef SANITIZER_SYMBOLIZER_H #define SANITIZER_SYMBOLIZER_H @@ -27,7 +22,6 @@ #include "sanitizer_allocator_internal.h" #include "sanitizer_internal_defs.h" #include "sanitizer_libc.h" -// WARNING: Do not include system headers here. See details above. namespace __sanitizer { |

