diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2013-08-13 15:33:00 +0000 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2013-08-13 15:33:00 +0000 |
| commit | 97f0eae0a5adfd9f72b32184c2cb9d3e51237f06 (patch) | |
| tree | 59d4086500ae1702938b1c4b28d94518f3f948b4 /compiler-rt/lib/tsan | |
| parent | 7757073c21e40e2735b23a7b097f3246d6071e3c (diff) | |
| download | bcm5719-llvm-97f0eae0a5adfd9f72b32184c2cb9d3e51237f06.tar.gz bcm5719-llvm-97f0eae0a5adfd9f72b32184c2cb9d3e51237f06.zip | |
tsan/msan: add halt_on_error flag
If halt_on_error==true, program terminates after reporting first error.
llvm-svn: 188279
Diffstat (limited to 'compiler-rt/lib/tsan')
| -rwxr-xr-x | compiler-rt/lib/tsan/check_cmake.sh | 1 | ||||
| -rw-r--r-- | compiler-rt/lib/tsan/lit_tests/halt_on_error.cc | 25 | ||||
| -rw-r--r-- | compiler-rt/lib/tsan/rtl/tsan_flags.cc | 2 | ||||
| -rw-r--r-- | compiler-rt/lib/tsan/rtl/tsan_flags.h | 2 | ||||
| -rw-r--r-- | compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc | 4 |
5 files changed, 33 insertions, 1 deletions
diff --git a/compiler-rt/lib/tsan/check_cmake.sh b/compiler-rt/lib/tsan/check_cmake.sh index 52c97c33909..922c3b60205 100755 --- a/compiler-rt/lib/tsan/check_cmake.sh +++ b/compiler-rt/lib/tsan/check_cmake.sh @@ -10,3 +10,4 @@ make -j64 make check-sanitizer -j64 make check-tsan -j64 make check-asan -j64 +make check-msan -j64 diff --git a/compiler-rt/lib/tsan/lit_tests/halt_on_error.cc b/compiler-rt/lib/tsan/lit_tests/halt_on_error.cc new file mode 100644 index 00000000000..fddaffff29a --- /dev/null +++ b/compiler-rt/lib/tsan/lit_tests/halt_on_error.cc @@ -0,0 +1,25 @@ +// RUN: %clang_tsan -O1 %s -o %t && TSAN_OPTIONS="$TSAN_OPTIONS halt_on_error=1" not %t 2>&1 | FileCheck %s +#include <pthread.h> +#include <stdio.h> + +int X; + +void *Thread(void *x) { + X = 42; + return 0; +} + +int main() { + fprintf(stderr, "BEFORE\n"); + pthread_t t; + pthread_create(&t, 0, Thread, 0); + X = 43; + pthread_join(t, 0); + fprintf(stderr, "AFTER\n"); + return 0; +} + +// CHECK: BEFORE +// CHECK: WARNING: ThreadSanitizer: data race +// CHECK-NOT: AFTER + diff --git a/compiler-rt/lib/tsan/rtl/tsan_flags.cc b/compiler-rt/lib/tsan/rtl/tsan_flags.cc index c062592f482..86e45f6457f 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_flags.cc +++ b/compiler-rt/lib/tsan/rtl/tsan_flags.cc @@ -52,6 +52,7 @@ void InitializeFlags(Flags *f, const char *env) { f->print_suppressions = false; f->print_benign = false; f->exitcode = 66; + f->halt_on_error = false; f->log_path = "stderr"; f->atexit_sleep_ms = 1000; f->verbosity = 0; @@ -83,6 +84,7 @@ void InitializeFlags(Flags *f, const char *env) { ParseFlag(env, &f->print_suppressions, "print_suppressions"); ParseFlag(env, &f->print_benign, "print_benign"); ParseFlag(env, &f->exitcode, "exitcode"); + ParseFlag(env, &f->halt_on_error, "halt_on_error"); ParseFlag(env, &f->log_path, "log_path"); ParseFlag(env, &f->atexit_sleep_ms, "atexit_sleep_ms"); ParseFlag(env, &f->verbosity, "verbosity"); diff --git a/compiler-rt/lib/tsan/rtl/tsan_flags.h b/compiler-rt/lib/tsan/rtl/tsan_flags.h index aaacd98a622..b517ccc3ffa 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_flags.h +++ b/compiler-rt/lib/tsan/rtl/tsan_flags.h @@ -58,6 +58,8 @@ struct Flags { bool print_benign; // Override exit status if something was reported. int exitcode; + // Exit after first reported error. + bool halt_on_error; // Write logs to "log_path.pid". // The special values are "stdout" and "stderr". // The default is "stderr". diff --git a/compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc b/compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc index 94419ce9c2b..bc26b6366c5 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc +++ b/compiler-rt/lib/tsan/rtl/tsan_rtl_report.cc @@ -527,7 +527,9 @@ bool OutputReport(Context *ctx, if (OnReport(rep, suppress_pc != 0)) return false; PrintReport(rep); - CTX()->nreported++; + ctx->nreported++; + if (flags()->halt_on_error) + internal__exit(flags()->exitcode); return true; } |

