diff options
author | Russell Gallop <russell.gallop@gmail.com> | 2019-10-10 10:56:52 +0000 |
---|---|---|
committer | Russell Gallop <russell.gallop@gmail.com> | 2019-10-10 10:56:52 +0000 |
commit | c48e0873af43eb245cdcca7b9822d2ff8646231c (patch) | |
tree | 3dd18e74053f68fa57da4840415694133a94d59c /compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp | |
parent | 186f1c58c5ea62b0149d47b2b7b5b3396589fdb0 (diff) | |
download | bcm5719-llvm-c48e0873af43eb245cdcca7b9822d2ff8646231c.tar.gz bcm5719-llvm-c48e0873af43eb245cdcca7b9822d2ff8646231c.zip |
Revert "[ASan] Do not misrepresent high value address dereferences as null dereferences"
As it was breaking bots running sanitizer lint check
This reverts r374265 (git b577efe4567f1f6a711ad36e1d17280dd1c4f009)
llvm-svn: 374308
Diffstat (limited to 'compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp')
-rw-r--r-- | compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp index fe9ea1a8200..d6699f3ed6f 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp @@ -191,14 +191,9 @@ static void ReportDeadlySignalImpl(const SignalContext &sig, u32 tid, SanitizerCommonDecorator d; Printf("%s", d.Warning()); const char *description = sig.Describe(); - if (sig.is_memory_access && !sig.is_true_faulting_addr) - Report("ERROR: %s: %s on unknown address (pc %p bp %p sp %p T%d)\n", - SanitizerToolName, description, (void *)sig.pc, (void *)sig.bp, - (void *)sig.sp, tid); - else - Report("ERROR: %s: %s on unknown address %p (pc %p bp %p sp %p T%d)\n", - SanitizerToolName, description, (void *)sig.addr, (void *)sig.pc, - (void *)sig.bp, (void *)sig.sp, tid); + Report("ERROR: %s: %s on unknown address %p (pc %p bp %p sp %p T%d)\n", + SanitizerToolName, description, (void *)sig.addr, (void *)sig.pc, + (void *)sig.bp, (void *)sig.sp, tid); Printf("%s", d.Default()); if (sig.pc < GetPageSizeCached()) Report("Hint: pc points to the zero page.\n"); @@ -208,11 +203,7 @@ static void ReportDeadlySignalImpl(const SignalContext &sig, u32 tid, ? "WRITE" : (sig.write_flag == SignalContext::READ ? "READ" : "UNKNOWN"); Report("The signal is caused by a %s memory access.\n", access_type); - if (!sig.is_true_faulting_addr) - Report("Hint: this fault was caused by a dereference of a high value " - "address (see registers below). Dissassemble the provided pc " - "to learn which register value was used.\n"); - else if (sig.addr < GetPageSizeCached()) + if (sig.addr < GetPageSizeCached()) Report("Hint: address points to the zero page.\n"); } MaybeReportNonExecRegion(sig.pc); |