summaryrefslogtreecommitdiffstats
path: root/compiler-rt/lib/builtins/divdc3.c
diff options
context:
space:
mode:
authorJordan Rupprecht <rupprecht@google.com>2018-09-24 20:39:19 +0000
committerJordan Rupprecht <rupprecht@google.com>2018-09-24 20:39:19 +0000
commitdc48c4fff4fdb61ebad48b62ae1f21a32af1e50c (patch)
tree78dc33292c84a5586e62f7a0f19830d357ee69b5 /compiler-rt/lib/builtins/divdc3.c
parent0b4ad7596f0141e9c804e8275b7ca4f33baa3efc (diff)
downloadbcm5719-llvm-dc48c4fff4fdb61ebad48b62ae1f21a32af1e50c.tar.gz
bcm5719-llvm-dc48c4fff4fdb61ebad48b62ae1f21a32af1e50c.zip
[compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible.
Summary: The complex division builtins (div?c3) use logb methods from libm to scale numbers during division and avoid rounding issues. However, these come from libm, meaning anyone that uses --rtlib=compiler-rt also has to include -lm. Implement logb* methods for standard ieee 754 floats so we can avoid -lm on those platforms, falling back to the old behavior (using either logb() or `__builtin_logb()`) when not supported. These new methods are defined internally as `__compiler_rt_logb` so as not to conflict with the libm definitions in any way. This fixes just the libm methods mentioned in PR32279 and PR28652. libc is still required, although that seems to not be an issue. Note: this is proposed as an alternative to just adding -lm: D49330. Reviewers: efriedma, compnerd, scanon, echristo Reviewed By: echristo Subscribers: jsji, echristo, nemanjai, dberris, mgorny, kbarton, delcypher, llvm-commits, #sanitizers Differential Revision: https://reviews.llvm.org/D49514 llvm-svn: 342917
Diffstat (limited to 'compiler-rt/lib/builtins/divdc3.c')
-rw-r--r--compiler-rt/lib/builtins/divdc3.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/compiler-rt/lib/builtins/divdc3.c b/compiler-rt/lib/builtins/divdc3.c
index 3c88390b5e7..392d6ecacde 100644
--- a/compiler-rt/lib/builtins/divdc3.c
+++ b/compiler-rt/lib/builtins/divdc3.c
@@ -12,6 +12,8 @@
* ===----------------------------------------------------------------------===
*/
+#define DOUBLE_PRECISION
+#include "fp_lib.h"
#include "int_lib.h"
#include "int_math.h"
@@ -21,7 +23,7 @@ COMPILER_RT_ABI Dcomplex
__divdc3(double __a, double __b, double __c, double __d)
{
int __ilogbw = 0;
- double __logbw = crt_logb(crt_fmax(crt_fabs(__c), crt_fabs(__d)));
+ double __logbw = __compiler_rt_logb(crt_fmax(crt_fabs(__c), crt_fabs(__d)));
if (crt_isfinite(__logbw))
{
__ilogbw = (int)__logbw;
OpenPOWER on IntegriCloud