diff options
| author | Kostya Kortchinsky <kostyak@google.com> | 2018-07-13 15:31:05 +0000 |
|---|---|---|
| committer | Kostya Kortchinsky <kostyak@google.com> | 2018-07-13 15:31:05 +0000 |
| commit | 4a547fb62d40a2406b5992e80cc27824f752b3db (patch) | |
| tree | 8884cfe20ff2f78e6fd6c699442d72eeca48cb63 /compiler-rt/CMakeLists.txt | |
| parent | ceabd50a5cff652dae468d872a8c31637c9ee415 (diff) | |
| download | bcm5719-llvm-4a547fb62d40a2406b5992e80cc27824f752b3db.tar.gz bcm5719-llvm-4a547fb62d40a2406b5992e80cc27824f752b3db.zip | |
[sanitizer] Use -Wl,-z,global on Android
Summary:
Use `-Wl,-z,global` for all Sanitizer shared libraries on
Android. We want them to be in the global group
(https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#changes-to-library-search-order)
to avoid any alloc/dealloc mismatch between the libc allocator & said library.
`audioserver` was one of the binary that exhibited the problem with Scudo,
this seems to fix it.
[edited for accuracy]
Reviewers: eugenis, alekseyshl
Reviewed By: eugenis
Subscribers: kubamracek, srhines, mgorny, delcypher, #sanitizers, llvm-commits
Differential Revision: https://reviews.llvm.org/D49198
llvm-svn: 337010
Diffstat (limited to 'compiler-rt/CMakeLists.txt')
| -rw-r--r-- | compiler-rt/CMakeLists.txt | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt index be4066f221e..77507b78a9f 100644 --- a/compiler-rt/CMakeLists.txt +++ b/compiler-rt/CMakeLists.txt @@ -333,6 +333,14 @@ endif() append_list_if(COMPILER_RT_HAS_LIBC c SANITIZER_COMMON_LINK_LIBS) +if(ANDROID) +# Put the Sanitizer shared libraries in the global group. For more details, see +# android-changes-for-ndk-developers.md#changes-to-library-search-order + if (COMPILER_RT_HAS_Z_GLOBAL) + list(APPEND SANITIZER_COMMON_LINK_FLAGS -Wl,-z,global) + endif() +endif() + if("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia") list(APPEND SANITIZER_COMMON_LINK_FLAGS -Wl,-z,defs,-z,now,-z,relro) list(APPEND SANITIZER_COMMON_LINK_LIBS zircon) |
