diff options
| author | Kaelyn Uhrain <rikka@google.com> | 2013-09-26 21:13:05 +0000 |
|---|---|---|
| committer | Kaelyn Uhrain <rikka@google.com> | 2013-09-26 21:13:05 +0000 |
| commit | f73430183afcedd5a331c4ac4d4f1ec6dac8f75f (patch) | |
| tree | 681d560406d77757efb0394ef8d1f6b61071e39f /clang | |
| parent | a1b4206a7018ca8f71e2d8564fc6f464d2bed1b7 (diff) | |
| download | bcm5719-llvm-f73430183afcedd5a331c4ac4d4f1ec6dac8f75f.tar.gz bcm5719-llvm-f73430183afcedd5a331c4ac4d4f1ec6dac8f75f.zip | |
Fix error recovery when a return type correction includes a new name specifier.
llvm-svn: 191459
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 7 | ||||
| -rw-r--r-- | clang/test/SemaCXX/typo-correction-pt2.cpp | 4 |
2 files changed, 7 insertions, 4 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 5997abe0296..62f65a580e6 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -426,8 +426,13 @@ bool Sema::DiagnoseUnknownTypeName(IdentifierInfo *&II, llvm_unreachable("could not have corrected a typo here"); } + CXXScopeSpec tmpSS; + if (Corrected.getCorrectionSpecifier()) + tmpSS.MakeTrivial(Context, Corrected.getCorrectionSpecifier(), + SourceRange(IILoc)); SuggestedType = getTypeName(*Corrected.getCorrectionAsIdentifierInfo(), - IILoc, S, SS, false, false, ParsedType(), + IILoc, S, tmpSS.isSet() ? &tmpSS : SS, false, + false, ParsedType(), /*IsCtorOrDtorName=*/false, /*NonTrivialTypeSourceInfo=*/true); } diff --git a/clang/test/SemaCXX/typo-correction-pt2.cpp b/clang/test/SemaCXX/typo-correction-pt2.cpp index f475b41a9f2..543a5823f71 100644 --- a/clang/test/SemaCXX/typo-correction-pt2.cpp +++ b/clang/test/SemaCXX/typo-correction-pt2.cpp @@ -47,9 +47,7 @@ public: }; Inner Outer::MyMethod(Inner arg) { // expected-error {{unknown type name 'Inner'; did you mean 'Outer::Inner'?}} - // TODO: Recovery needs to be fixed/added for the typo-correction of the - // return type so the below error isn't still generated. - return Inner(); // expected-error {{no viable conversion from 'class_member_typo_corrections::Outer::Inner' to 'int'}} + return Inner(); } class Result { |

