summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2010-11-02 16:54:00 +0000
committerFariborz Jahanian <fjahanian@apple.com>2010-11-02 16:54:00 +0000
commitdc9bc5aeb8cc34f9fda7d23e0ddb7c3d50f15bea (patch)
tree977b31c4189c99af2c8252973f358199a1214a0a /clang
parent5d7be2e6179b165f99ad1d6853b48be9ac5883ba (diff)
downloadbcm5719-llvm-dc9bc5aeb8cc34f9fda7d23e0ddb7c3d50f15bea.tar.gz
bcm5719-llvm-dc9bc5aeb8cc34f9fda7d23e0ddb7c3d50f15bea.zip
Fix a crash mangling decayed val argument-typed function.
// rdar: //8620510 and PR7666 llvm-svn: 118019
Diffstat (limited to 'clang')
-rw-r--r--clang/lib/CodeGen/Mangle.cpp4
-rw-r--r--clang/test/CodeGenCXX/mangle.cpp6
2 files changed, 9 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/Mangle.cpp b/clang/lib/CodeGen/Mangle.cpp
index e47d9cb43a6..37ecf285983 100644
--- a/clang/lib/CodeGen/Mangle.cpp
+++ b/clang/lib/CodeGen/Mangle.cpp
@@ -1324,7 +1324,9 @@ void CXXNameMangler::mangleType(const ConstantArrayType *T) {
}
void CXXNameMangler::mangleType(const VariableArrayType *T) {
Out << 'A';
- mangleExpression(T->getSizeExpr());
+ // decayed vla types (size 0) will just be skipped.
+ if (T->getSizeExpr())
+ mangleExpression(T->getSizeExpr());
Out << '_';
mangleType(T->getElementType());
}
diff --git a/clang/test/CodeGenCXX/mangle.cpp b/clang/test/CodeGenCXX/mangle.cpp
index 55357c7d63a..e78ad3996ee 100644
--- a/clang/test/CodeGenCXX/mangle.cpp
+++ b/clang/test/CodeGenCXX/mangle.cpp
@@ -624,3 +624,9 @@ namespace test20 {
template <class T> void test1(decltype(f<>(T()))) {}
template void test1<int>(decltype(f<>(int())));
}
+
+// rdar:// 8620510
+namespace test21 {
+ // CHECK: define void @_ZN6test2112vla_arg_funcEiPA_i(
+ void vla_arg_func(int X, int a[X][X]) {}
+}
OpenPOWER on IntegriCloud