diff options
| author | Akira Hatanaka <ahatanaka@apple.com> | 2017-01-26 18:51:10 +0000 |
|---|---|---|
| committer | Akira Hatanaka <ahatanaka@apple.com> | 2017-01-26 18:51:10 +0000 |
| commit | c05c42567e0a2b5e5434cf0879f8795e7c1b2adb (patch) | |
| tree | a9ec57a0d34755f57e506570f89ed82a0043b39b /clang | |
| parent | 66e3a3d0acc95a57938852030c260b8b0b47510a (diff) | |
| download | bcm5719-llvm-c05c42567e0a2b5e5434cf0879f8795e7c1b2adb.tar.gz bcm5719-llvm-c05c42567e0a2b5e5434cf0879f8795e7c1b2adb.zip | |
Turn on -Wblock-capture-autoreleasing by default.
Turning on the warning by default helps the users as it's a common
mistake to capture out-parameters in a block without ensuring the object
assigned doesn't get released.
rdar://problem/30200058
llvm-svn: 293199
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/include/clang/Basic/DiagnosticSemaKinds.td | 2 | ||||
| -rw-r--r-- | clang/test/SemaObjC/arc.m | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td index 0a0ddda0edc..7f7ef1848a0 100644 --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -5185,7 +5185,7 @@ def err_arc_inconsistent_property_ownership : Error< def warn_block_capture_autoreleasing : Warning< "block captures an autoreleasing out-parameter, which may result in " "use-after-free bugs">, - InGroup<BlockCaptureAutoReleasing>, DefaultIgnore; + InGroup<BlockCaptureAutoReleasing>; def note_declare_parameter_autoreleasing : Note< "declare the parameter __autoreleasing explicitly to suppress this warning">; def note_declare_parameter_strong : Note< diff --git a/clang/test/SemaObjC/arc.m b/clang/test/SemaObjC/arc.m index 2aeecdb4440..72c07a9ff10 100644 --- a/clang/test/SemaObjC/arc.m +++ b/clang/test/SemaObjC/arc.m @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-runtime-has-weak -fsyntax-only -fobjc-arc -fblocks -verify -Wno-objc-root-class -Wblock-capture-autoreleasing %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-runtime-has-weak -fsyntax-only -fobjc-arc -fblocks -verify -Wno-objc-root-class %s typedef unsigned long NSUInteger; typedef const void * CFTypeRef; |
