summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorFariborz Jahanian <fjahanian@apple.com>2014-01-15 00:59:25 +0000
committerFariborz Jahanian <fjahanian@apple.com>2014-01-15 00:59:25 +0000
commitbae1bcb6bf47c6227aaae4758ff91c52f8fc4e9b (patch)
tree5a8be4e4af2346cdf5ddaaddf4b0dcfebff422a9 /clang
parent0f83390540211e3a456d6b16b918c436cafdd654 (diff)
downloadbcm5719-llvm-bae1bcb6bf47c6227aaae4758ff91c52f8fc4e9b.tar.gz
bcm5719-llvm-bae1bcb6bf47c6227aaae4758ff91c52f8fc4e9b.zip
ObjectiveC. Improve on diagnostics per Jordan's feedback.
llvm-svn: 199278
Diffstat (limited to 'clang')
-rw-r--r--clang/include/clang/Basic/DiagnosticSemaKinds.td2
-rw-r--r--clang/test/PCH/chain-selectors.m6
-rw-r--r--clang/test/SemaObjC/selector-3.m6
3 files changed, 7 insertions, 7 deletions
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td
index e956e851b63..1de0c0fd119 100644
--- a/clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -855,7 +855,7 @@ def warn_auto_implicit_atomic_property : Warning<
"property is assumed atomic when auto-synthesizing the property">,
InGroup<ImplicitAtomic>, DefaultIgnore;
def warn_unimplemented_selector: Warning<
- "using @selector on method %0 with no implementation in translation unit">,
+ "no method with selector %0 is implemented in this translation unit">,
InGroup<Selector>, DefaultIgnore;
def warn_unimplemented_protocol_method : Warning<
"method %0 in protocol %1 not implemented">, InGroup<Protocol>;
diff --git a/clang/test/PCH/chain-selectors.m b/clang/test/PCH/chain-selectors.m
index 5de17725ff9..2551c643cc8 100644
--- a/clang/test/PCH/chain-selectors.m
+++ b/clang/test/PCH/chain-selectors.m
@@ -18,9 +18,9 @@ void bar() {
// FIXME: Can't verify notes in headers
//[a f2];
- (void)@selector(x); // expected-warning {{using @selector on method 'x' with no implementation in translation unit}}
- (void)@selector(y); // expected-warning {{using @selector on method 'y' with no implementation in translation unit}}
- (void)@selector(e); // expected-warning {{using @selector on method 'e' with no implementation in translation unit}}
+ (void)@selector(x); // expected-warning {{no method with selector 'x' is implemented in this translation unit}}
+ (void)@selector(y); // expected-warning {{no method with selector 'y' is implemented in this translation unit}}
+ (void)@selector(e); // expected-warning {{no method with selector 'e' is implemented in this translation unit}}
}
@implementation X (Blah)
diff --git a/clang/test/SemaObjC/selector-3.m b/clang/test/SemaObjC/selector-3.m
index 76e14b16c1f..37c4ec19dfd 100644
--- a/clang/test/SemaObjC/selector-3.m
+++ b/clang/test/SemaObjC/selector-3.m
@@ -14,7 +14,7 @@
- (void) foo
{
SEL a,b,c;
- a = @selector(b1ar); // expected-warning {{using @selector on method 'b1ar' with no implementation in translation unit}}
+ a = @selector(b1ar); // expected-warning {{no method with selector 'b1ar' is implemented in this translation unit}}
b = @selector(bar);
}
@end
@@ -25,7 +25,7 @@
SEL func()
{
- return @selector(length); // expected-warning {{using @selector on method 'length' with no implementation in translation unit}}
+ return @selector(length); // expected-warning {{no method with selector 'length' is implemented in this translation unit}}
}
// rdar://9545564
@@ -69,7 +69,7 @@ extern SEL MySelector(SEL s);
@implementation INTF
- (void) Meth {
- if( [cnx respondsToSelector:MySelector(@selector( _setQueue: ))] ) // expected-warning {{using @selector on method '_setQueue:' with no implementation in translation unit}}
+ if( [cnx respondsToSelector:MySelector(@selector( _setQueue: ))] ) // expected-warning {{no method with selector '_setQueue:' is implemented in this translation unit}}
{
}
OpenPOWER on IntegriCloud