summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorRichard Smith <richard-llvm@metafoo.co.uk>2012-06-08 21:35:42 +0000
committerRichard Smith <richard-llvm@metafoo.co.uk>2012-06-08 21:35:42 +0000
commitb3a1df03a97e9e7c3d6a69d2514aeefb360b341a (patch)
treee1274556f653d94406a5951a66c94cce8aaaea5c /clang
parentd49a33e86cd8ca68f35d2d839e65b03b4892f3cf (diff)
downloadbcm5719-llvm-b3a1df03a97e9e7c3d6a69d2514aeefb360b341a.tar.gz
bcm5719-llvm-b3a1df03a97e9e7c3d6a69d2514aeefb360b341a.zip
PR13051: Only suggest the 'template' and 'operator' keywords when performing
typo-correction after a scope specifier. llvm-svn: 158231
Diffstat (limited to 'clang')
-rw-r--r--clang/lib/Sema/SemaLookup.cpp13
-rw-r--r--clang/test/SemaCXX/typo-correction.cpp13
2 files changed, 24 insertions, 2 deletions
diff --git a/clang/lib/Sema/SemaLookup.cpp b/clang/lib/Sema/SemaLookup.cpp
index 91d76de1729..ded441cac68 100644
--- a/clang/lib/Sema/SemaLookup.cpp
+++ b/clang/lib/Sema/SemaLookup.cpp
@@ -3533,7 +3533,16 @@ static void LookupPotentialTypoResult(Sema &SemaRef,
/// \brief Add keywords to the consumer as possible typo corrections.
static void AddKeywordsToConsumer(Sema &SemaRef,
TypoCorrectionConsumer &Consumer,
- Scope *S, CorrectionCandidateCallback &CCC) {
+ Scope *S, CorrectionCandidateCallback &CCC,
+ bool AfterNestedNameSpecifier) {
+ if (AfterNestedNameSpecifier) {
+ // For 'X::', we know exactly which keywords can appear next.
+ Consumer.addKeywordResult("template");
+ if (CCC.WantExpressionKeywords)
+ Consumer.addKeywordResult("operator");
+ return;
+ }
+
if (CCC.WantObjCSuper)
Consumer.addKeywordResult("super");
@@ -3823,7 +3832,7 @@ TypoCorrection Sema::CorrectTypo(const DeclarationNameInfo &TypoName,
}
}
- AddKeywordsToConsumer(*this, Consumer, S, CCC);
+ AddKeywordsToConsumer(*this, Consumer, S, CCC, SS && SS->isNotEmpty());
// If we haven't found anything, we're done.
if (Consumer.empty()) {
diff --git a/clang/test/SemaCXX/typo-correction.cpp b/clang/test/SemaCXX/typo-correction.cpp
index fb07ce127e7..90fdb221f92 100644
--- a/clang/test/SemaCXX/typo-correction.cpp
+++ b/clang/test/SemaCXX/typo-correction.cpp
@@ -206,3 +206,16 @@ namespace foobar { struct Thing {}; }
namespace bazquux { struct Thing {}; }
void f() { Thing t; } // expected-error{{unknown type name 'Thing'}}
}
+
+namespace PR13051 {
+ template<typename T> struct S {
+ template<typename U> void f();
+ operator bool() const;
+ };
+
+ void f() {
+ f(&S<int>::tempalte f<int>); // expected-error{{did you mean 'template'?}}
+ f(&S<int>::opeartor bool); // expected-error{{did you mean 'operator'?}}
+ f(&S<int>::foo); // expected-error-re{{no member named 'foo' in 'PR13051::S<int>'$}}
+ }
+}
OpenPOWER on IntegriCloud