diff options
author | David Blaikie <dblaikie@gmail.com> | 2015-04-17 00:19:34 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2015-04-17 00:19:34 +0000 |
commit | ab8f7d58760cfe52a530c578f68d0cc8a2d91e1b (patch) | |
tree | 7f8d12065841d136f22fd102ada04d9325f6c392 /clang | |
parent | 05f53aee0fe9c25eb6477b3d6e07f6178a67ba11 (diff) | |
download | bcm5719-llvm-ab8f7d58760cfe52a530c578f68d0cc8a2d91e1b.tar.gz bcm5719-llvm-ab8f7d58760cfe52a530c578f68d0cc8a2d91e1b.zip |
Improve const-ness
This allows callers to pass a char ** (such as the one coming from the
standard decreed main declaration - even though everyone usually puts
const on that themselves).
llvm-svn: 235150
Diffstat (limited to 'clang')
-rw-r--r-- | clang/include/clang/Tooling/CompilationDatabase.h | 2 | ||||
-rw-r--r-- | clang/lib/Tooling/CompilationDatabase.cpp | 8 |
2 files changed, 4 insertions, 6 deletions
diff --git a/clang/include/clang/Tooling/CompilationDatabase.h b/clang/include/clang/Tooling/CompilationDatabase.h index 27c16524e62..e5b95af3aef 100644 --- a/clang/include/clang/Tooling/CompilationDatabase.h +++ b/clang/include/clang/Tooling/CompilationDatabase.h @@ -178,7 +178,7 @@ public: /// \param Argv Points to the command line arguments. /// \param Directory The base directory used in the FixedCompilationDatabase. static FixedCompilationDatabase *loadFromCommandLine(int &Argc, - const char **Argv, + const char *const *Argv, Twine Directory = "."); /// \brief Constructs a compilation data base from a specified directory diff --git a/clang/lib/Tooling/CompilationDatabase.cpp b/clang/lib/Tooling/CompilationDatabase.cpp index 73564376a58..2514f027f47 100644 --- a/clang/lib/Tooling/CompilationDatabase.cpp +++ b/clang/lib/Tooling/CompilationDatabase.cpp @@ -283,11 +283,9 @@ static bool stripPositionalArgs(std::vector<const char *> Args, return true; } -FixedCompilationDatabase * -FixedCompilationDatabase::loadFromCommandLine(int &Argc, - const char **Argv, - Twine Directory) { - const char **DoubleDash = std::find(Argv, Argv + Argc, StringRef("--")); +FixedCompilationDatabase *FixedCompilationDatabase::loadFromCommandLine( + int &Argc, const char *const *Argv, Twine Directory) { + const char *const *DoubleDash = std::find(Argv, Argv + Argc, StringRef("--")); if (DoubleDash == Argv + Argc) return nullptr; std::vector<const char *> CommandLine(DoubleDash + 1, Argv + Argc); |