diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2010-10-14 23:31:39 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2010-10-14 23:31:39 +0000 |
| commit | 9c07e1767dc69fdd12dc99fcf293b38e4843e24c (patch) | |
| tree | be4c0af82696e28002ff773a381ab746424b22e7 /clang | |
| parent | 89efff37637de17ddf679f76edd0d1113dee41f7 (diff) | |
| download | bcm5719-llvm-9c07e1767dc69fdd12dc99fcf293b38e4843e24c.tar.gz bcm5719-llvm-9c07e1767dc69fdd12dc99fcf293b38e4843e24c.zip | |
Rewrite bug fix rewriting a property assignment when
its RHS is an ivar. Fixes //rdar: //8541517.
llvm-svn: 116539
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/Rewrite/RewriteObjC.cpp | 6 | ||||
| -rw-r--r-- | clang/test/Rewriter/property-dot-syntax.mm | 18 |
2 files changed, 24 insertions, 0 deletions
diff --git a/clang/lib/Rewrite/RewriteObjC.cpp b/clang/lib/Rewrite/RewriteObjC.cpp index 8532bc7f13c..4c929a246b9 100644 --- a/clang/lib/Rewrite/RewriteObjC.cpp +++ b/clang/lib/Rewrite/RewriteObjC.cpp @@ -5479,6 +5479,12 @@ Stmt *RewriteObjC::RewriteFunctionBodyOrGlobalInitializer(Stmt *S) { // ^(NSURL *errorURL, NSError *error) { return (BOOL)1; }; SourceRange SrcRange = BinOp->getSourceRange(); Stmt *newStmt = RewriteFunctionBodyOrGlobalInitializer(BinOp->getRHS()); + // Need to rewrite the ivar access expression if need be. + if (isa<ObjCIvarRefExpr>(newStmt)) { + bool replaced = false; + newStmt = RewriteObjCNestedIvarRefExpr(newStmt, replaced); + } + DisableReplaceStmt = false; // // Unlike the main iterator, we explicily avoid changing 'BinOp'. If diff --git a/clang/test/Rewriter/property-dot-syntax.mm b/clang/test/Rewriter/property-dot-syntax.mm index 965d1e7c6ff..846bd824b53 100644 --- a/clang/test/Rewriter/property-dot-syntax.mm +++ b/clang/test/Rewriter/property-dot-syntax.mm @@ -26,3 +26,21 @@ void *sel_registerName(const char *); } @end +//rdar: // 8541517 +@interface A { } +@property (retain) NSString *scheme; +@end + +@interface B : A { + NSString* _schemeName; +} +@end + + +@implementation B +-(void) test { + B *b; + b.scheme = _schemeName; // error because of this line +} +@end + |

