diff options
author | Hans Wennborg <hans@hanshq.net> | 2013-09-18 00:17:07 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2013-09-18 00:17:07 +0000 |
commit | 9b7c8a378a51af01c652d424a256c1cabf8c59dd (patch) | |
tree | 0e3e5fff7cf99ece1c0c2d4c2ebb88e2d4fadab8 /clang | |
parent | eacc287b496420594a4f1d7c2d0da341c7855630 (diff) | |
download | bcm5719-llvm-9b7c8a378a51af01c652d424a256c1cabf8c59dd.tar.gz bcm5719-llvm-9b7c8a378a51af01c652d424a256c1cabf8c59dd.zip |
Revert "Move using directive from Job.h to Job.cpp" (r190902)
Seems like it was intentional to export ArgStringList as
driver::ArgStringList, and e.g. examples/clang-interpreter/main.cpp
uses it this way.
However, exporting it with a typedef seems like a more common way to do it.
llvm-svn: 190906
Diffstat (limited to 'clang')
-rw-r--r-- | clang/include/clang/Driver/Job.h | 9 | ||||
-rw-r--r-- | clang/lib/Driver/Job.cpp | 1 |
2 files changed, 6 insertions, 4 deletions
diff --git a/clang/include/clang/Driver/Job.h b/clang/include/clang/Driver/Job.h index c4e6a311854..7b91e4e9e48 100644 --- a/clang/include/clang/Driver/Job.h +++ b/clang/include/clang/Driver/Job.h @@ -24,6 +24,9 @@ class Action; class Command; class Tool; +// Users of this class will use clang::driver::ArgStringList. +typedef llvm::opt::ArgStringList ArgStringList; + class Job { public: enum JobClass { @@ -65,11 +68,11 @@ class Command : public Job { /// The list of program arguments (not including the implicit first /// argument, which will be the executable). - llvm::opt::ArgStringList Arguments; + ArgStringList Arguments; public: Command(const Action &_Source, const Tool &_Creator, const char *_Executable, - const llvm::opt::ArgStringList &_Arguments); + const ArgStringList &_Arguments); virtual void Print(llvm::raw_ostream &OS, const char *Terminator, bool Quote, bool CrashReport = false) const; @@ -83,7 +86,7 @@ public: /// getCreator - Return the Tool which caused the creation of this job. const Tool &getCreator() const { return Creator; } - const llvm::opt::ArgStringList &getArguments() const { return Arguments; } + const ArgStringList &getArguments() const { return Arguments; } static bool classof(const Job *J) { return J->getKind() == CommandClass; diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp index 43518ad8f97..4e4c664c8f7 100644 --- a/clang/lib/Driver/Job.cpp +++ b/clang/lib/Driver/Job.cpp @@ -15,7 +15,6 @@ #include "llvm/Support/raw_ostream.h" #include <cassert> using namespace clang::driver; -using llvm::opt::ArgStringList; using llvm::raw_ostream; using llvm::StringRef; |