diff options
author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2019-11-10 10:31:03 -0800 |
---|---|---|
committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2019-11-10 11:18:33 -0800 |
commit | 8e9e433a2af7c435923ba71ea7d75374408b0b32 (patch) | |
tree | f01bb1e2375b23427e9d3b6c0303e093ff5ae9c8 /clang | |
parent | 7874db75ef41f5c387f83e1d0bd16607721ddf89 (diff) | |
download | bcm5719-llvm-8e9e433a2af7c435923ba71ea7d75374408b0b32.tar.gz bcm5719-llvm-8e9e433a2af7c435923ba71ea7d75374408b0b32.zip |
clang/Modules: Remove unused parameter from ModuleManager::removeModules
The other paremeters appear to be sufficient to determine which modules
have just been loaded and need to be removed, so stop collecting and
sending in that set explicitly.
Diffstat (limited to 'clang')
-rw-r--r-- | clang/include/clang/Serialization/ModuleManager.h | 4 | ||||
-rw-r--r-- | clang/lib/Serialization/ASTReader.cpp | 6 | ||||
-rw-r--r-- | clang/lib/Serialization/ModuleManager.cpp | 5 |
3 files changed, 3 insertions, 12 deletions
diff --git a/clang/include/clang/Serialization/ModuleManager.h b/clang/include/clang/Serialization/ModuleManager.h index 5b3b22be759..5f20fd7d2ec 100644 --- a/clang/include/clang/Serialization/ModuleManager.h +++ b/clang/include/clang/Serialization/ModuleManager.h @@ -255,9 +255,7 @@ public: std::string &ErrorStr); /// Remove the modules starting from First (to the end). - void removeModules(ModuleIterator First, - llvm::SmallPtrSetImpl<ModuleFile *> &LoadedSuccessfully, - ModuleMap *modMap); + void removeModules(ModuleIterator First, ModuleMap *modMap); /// Add an in-memory buffer the list of known buffers void addInMemoryBuffer(StringRef FileName, diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp index 2d3884ebe02..b8bdfef791b 100644 --- a/clang/lib/Serialization/ASTReader.cpp +++ b/clang/lib/Serialization/ASTReader.cpp @@ -4185,11 +4185,7 @@ ASTReader::ASTReadResult ASTReader::ReadAST(StringRef FileName, case VersionMismatch: case ConfigurationMismatch: case HadErrors: { - llvm::SmallPtrSet<ModuleFile *, 4> LoadedSet; - for (const ImportedModule &IM : Loaded) - LoadedSet.insert(IM.Mod); - - ModuleMgr.removeModules(ModuleMgr.begin() + NumModules, LoadedSet, + ModuleMgr.removeModules(ModuleMgr.begin() + NumModules, PP.getLangOpts().Modules ? &PP.getHeaderSearchInfo().getModuleMap() : nullptr); diff --git a/clang/lib/Serialization/ModuleManager.cpp b/clang/lib/Serialization/ModuleManager.cpp index 4b9f20fca4f..669ab901731 100644 --- a/clang/lib/Serialization/ModuleManager.cpp +++ b/clang/lib/Serialization/ModuleManager.cpp @@ -219,10 +219,7 @@ ModuleManager::addModule(StringRef FileName, ModuleKind Type, return NewlyLoaded; } -void ModuleManager::removeModules( - ModuleIterator First, - llvm::SmallPtrSetImpl<ModuleFile *> &LoadedSuccessfully, - ModuleMap *modMap) { +void ModuleManager::removeModules(ModuleIterator First, ModuleMap *modMap) { auto Last = end(); if (First == Last) return; |