summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorSimon Pilgrim <llvm-dev@redking.me.uk>2020-01-14 13:23:56 +0000
committerSimon Pilgrim <llvm-dev@redking.me.uk>2020-01-14 14:00:36 +0000
commit7ec7a6e5bfa745c285d5c651af02b93f2cb923e1 (patch)
treef312b9aaf3da96afb976dd8bad73978c167aa43a /clang
parenta705cf1acbe94498f7fcca4e89be6d4820271227 (diff)
downloadbcm5719-llvm-7ec7a6e5bfa745c285d5c651af02b93f2cb923e1.tar.gz
bcm5719-llvm-7ec7a6e5bfa745c285d5c651af02b93f2cb923e1.zip
Fix "null pointer passed to nonnull argument" clang static analyzer warnings. NFCI.
Assert that the memcpy arguments are valid.
Diffstat (limited to 'clang')
-rw-r--r--clang/lib/AST/NestedNameSpecifier.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/clang/lib/AST/NestedNameSpecifier.cpp b/clang/lib/AST/NestedNameSpecifier.cpp
index 09d85102585..137953fa820 100644
--- a/clang/lib/AST/NestedNameSpecifier.cpp
+++ b/clang/lib/AST/NestedNameSpecifier.cpp
@@ -472,7 +472,7 @@ TypeLoc NestedNameSpecifierLoc::getTypeLoc() const {
}
static void Append(char *Start, char *End, char *&Buffer, unsigned &BufferSize,
- unsigned &BufferCapacity) {
+ unsigned &BufferCapacity) {
if (Start == End)
return;
@@ -489,9 +489,9 @@ static void Append(char *Start, char *End, char *&Buffer, unsigned &BufferSize,
Buffer = NewBuffer;
BufferCapacity = NewCapacity;
}
-
+ assert(Buffer && Start && End && End > Start && "Illegal memory buffer copy");
memcpy(Buffer + BufferSize, Start, End - Start);
- BufferSize += End-Start;
+ BufferSize += End - Start;
}
/// Save a source location to the given buffer.
OpenPOWER on IntegriCloud