diff options
| author | Yaxun Liu <Yaxun.Liu@amd.com> | 2018-08-30 15:10:20 +0000 |
|---|---|---|
| committer | Yaxun Liu <Yaxun.Liu@amd.com> | 2018-08-30 15:10:20 +0000 |
| commit | 5e98c2b69db07905348e8d5b1778bbba94c56531 (patch) | |
| tree | a99153fc06cb52202ebb9b18960c6c47bf428010 /clang | |
| parent | e6ce8da0252aba2642eb7879e1ff87beba568f67 (diff) | |
| download | bcm5719-llvm-5e98c2b69db07905348e8d5b1778bbba94c56531.tar.gz bcm5719-llvm-5e98c2b69db07905348e8d5b1778bbba94c56531.zip | |
[HIP] Add -fvisibility hidden option to clang
AMDGPU target need -fvisibility hidden option for clang to
work around a limitation of no PLT support, otherwise there is compilation
error at -O0.
Differential Revision: https://reviews.llvm.org/D51434
llvm-svn: 341077
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/Driver/ToolChains/HIP.cpp | 6 | ||||
| -rw-r--r-- | clang/test/Driver/hip-toolchain.hip | 6 |
2 files changed, 10 insertions, 2 deletions
diff --git a/clang/lib/Driver/ToolChains/HIP.cpp b/clang/lib/Driver/ToolChains/HIP.cpp index 03acf45a9b3..6efcfaee8fd 100644 --- a/clang/lib/Driver/ToolChains/HIP.cpp +++ b/clang/lib/Driver/ToolChains/HIP.cpp @@ -247,6 +247,12 @@ void HIPToolChain::addClangTargetOptions( if (DriverArgs.hasFlag(options::OPT_fcuda_rdc, options::OPT_fno_cuda_rdc, false)) CC1Args.push_back("-fcuda-rdc"); + + // Default to "hidden" visibility, as object level linking will not be + // supported for the foreseeable future. + if (!DriverArgs.hasArg(options::OPT_fvisibility_EQ, + options::OPT_fvisibility_ms_compat)) + CC1Args.append({"-fvisibility", "hidden"}); } llvm::opt::DerivedArgList * diff --git a/clang/test/Driver/hip-toolchain.hip b/clang/test/Driver/hip-toolchain.hip index 7e0bdc3ca0c..8bdce487b1d 100644 --- a/clang/test/Driver/hip-toolchain.hip +++ b/clang/test/Driver/hip-toolchain.hip @@ -15,13 +15,15 @@ // CHECK: [[CLANG:".*clang.*"]] "-cc1" "-triple" "amdgcn-amd-amdhsa" // CHECK-SAME: "-aux-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" // CHECK-SAME: {{.*}} "-main-file-name" "a.cu" {{.*}} "-target-cpu" "gfx803" -// CHECK-SAME: "-fcuda-is-device" {{.*}} "-o" [[A_BC:".*bc"]] "-x" "hip" +// CHECK-SAME: "-fcuda-is-device" "-fvisibility" "hidden" +// CHECK-SAME: {{.*}} "-o" [[A_BC:".*bc"]] "-x" "hip" // CHECK-SAME: {{.*}} [[A_SRC:".*a.cu"]] // CHECK: [[CLANG]] "-cc1" "-triple" "amdgcn-amd-amdhsa" // CHECK-SAME: "-aux-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" // CHECK-SAME: {{.*}} "-main-file-name" "b.hip" {{.*}} "-target-cpu" "gfx803" -// CHECK-SAME: "-fcuda-is-device" {{.*}} "-o" [[B_BC:".*bc"]] "-x" "hip" +// CHECK-SAME: "-fcuda-is-device" "-fvisibility" "hidden" +// CHECK-SAME: {{.*}} "-o" [[B_BC:".*bc"]] "-x" "hip" // CHECK-SAME: {{.*}} [[B_SRC:".*b.hip"]] // CHECK: [[LLVM_LINK:"*.llvm-link"]] [[A_BC]] [[B_BC]] |
