diff options
| author | Richard Smith <richard-llvm@metafoo.co.uk> | 2011-10-28 23:26:52 +0000 |
|---|---|---|
| committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2011-10-28 23:26:52 +0000 |
| commit | 472d4953727a2b4c508aa99e9f15e1229a44e91c (patch) | |
| tree | 217ec1f1adb60bb939e900955343e2101b3ffc66 /clang | |
| parent | c6674fd597ad02f115a96405e1a1b0f65c7ba19c (diff) | |
| download | bcm5719-llvm-472d4953727a2b4c508aa99e9f15e1229a44e91c.tar.gz bcm5719-llvm-472d4953727a2b4c508aa99e9f15e1229a44e91c.zip | |
Fix assertion in constant expression evaluation. The LHS of a floating-point
binary operator isn't an rvalue if it's an assignment operator.
llvm-svn: 143250
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/AST/ExprConstant.cpp | 4 | ||||
| -rw-r--r-- | clang/test/Sema/const-eval.c | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index 89bcacf2bba..6e2e15c6cb6 100644 --- a/clang/lib/AST/ExprConstant.cpp +++ b/clang/lib/AST/ExprConstant.cpp @@ -2492,8 +2492,8 @@ bool FloatExprEvaluator::VisitBinaryOperator(const BinaryOperator *E) { return Visit(E->getRHS()); } - // We can't evaluate pointer-to-member operations. - if (E->isPtrMemOp()) + // We can't evaluate pointer-to-member operations or assignments. + if (E->isPtrMemOp() || E->isAssignmentOp()) return false; // FIXME: Diagnostics? I really don't understand how the warnings diff --git a/clang/test/Sema/const-eval.c b/clang/test/Sema/const-eval.c index bdb40ae54be..6dcc6db7659 100644 --- a/clang/test/Sema/const-eval.c +++ b/clang/test/Sema/const-eval.c @@ -86,3 +86,5 @@ void rdar8875946() { double _Complex P; float _Complex P2 = 3.3f + P; } + +double d = (d = 0.0); // expected-error {{not a compile-time constant}} |
