summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorSteve Naroff <snaroff@apple.com>2009-10-08 23:45:10 +0000
committerSteve Naroff <snaroff@apple.com>2009-10-08 23:45:10 +0000
commit3b08630b06a41235f4f9bba302ff3a643cca943f (patch)
tree53a3765159a00f1b81b5fdf345a01dd312731d81 /clang
parentb851eb356a462a2894af757d2d0fc766e22b0d30 (diff)
downloadbcm5719-llvm-3b08630b06a41235f4f9bba302ff3a643cca943f.tar.gz
bcm5719-llvm-3b08630b06a41235f4f9bba302ff3a643cca943f.zip
- Fixup SortCodeCompleteResult() to properly sort keywords on Mac OS (compare was system dependent). Worked on Linux, failed on Mac OS (which caused the recently added testcase to fail on Linux).
- Sort results in testcase. llvm-svn: 83597
Diffstat (limited to 'clang')
-rw-r--r--clang/lib/Sema/SemaCodeComplete.cpp2
-rw-r--r--clang/test/CodeCompletion/property.m18
2 files changed, 10 insertions, 10 deletions
diff --git a/clang/lib/Sema/SemaCodeComplete.cpp b/clang/lib/Sema/SemaCodeComplete.cpp
index b6487026501..d7697a7333a 100644
--- a/clang/lib/Sema/SemaCodeComplete.cpp
+++ b/clang/lib/Sema/SemaCodeComplete.cpp
@@ -986,7 +986,7 @@ namespace {
Y.Declaration->getDeclName());
case Result::RK_Keyword:
- return strcmp(X.Keyword, Y.Keyword) == -1;
+ return strcmp(X.Keyword, Y.Keyword) < 0;
}
// Silence GCC warning.
diff --git a/clang/test/CodeCompletion/property.m b/clang/test/CodeCompletion/property.m
index a8dd2ba2eb4..7f2321ee139 100644
--- a/clang/test/CodeCompletion/property.m
+++ b/clang/test/CodeCompletion/property.m
@@ -7,22 +7,22 @@
@property(copy) Foo *myprop;
@property(retain, nonatomic) id xx;
// RUN: clang-cc -fsyntax-only -code-completion-at=%s:7:11 %s -o - | FileCheck -check-prefix=CC1 %s &&
-// CC1: readonly
-// CC1-NEXT: assign
-// CC1-NEXT: readwrite
-// CC1-NEXT: retain
+// CC1: assign
// CC1-NEXT: copy
+// CC1-NEXT: getter
// CC1-NEXT: nonatomic
+// CC1-NEXT: readonly
+// CC1-NEXT: readwrite
+// CC1-NEXT: retain
// CC1-NEXT: setter
-// CC1-NEXT: getter
// RUN: clang-cc -fsyntax-only -code-completion-at=%s:8:18 %s -o - | FileCheck -check-prefix=CC2 %s
-// CC2: readonly
-// CC2-NEXT: assign
-// CC2-NEXT: readwrite
+// CC2: assign
// CC2-NEXT: copy
+// CC2-NEXT: getter
// CC2-NEXT: nonatomic
+// CC2-NEXT: readonly
+// CC2-NEXT: readwrite
// CC2-NEXT: setter
-// CC2-NEXT: getter
@end
OpenPOWER on IntegriCloud