summaryrefslogtreecommitdiffstats
path: root/clang
diff options
context:
space:
mode:
authorEli Friedman <eli.friedman@gmail.com>2012-12-19 00:26:58 +0000
committerEli Friedman <eli.friedman@gmail.com>2012-12-19 00:26:58 +0000
commit39b685e4d13c4c490019f1a10ecf7f9fde7a8f89 (patch)
tree8a6afdbb69b54870264bb27ec09246bb0a291f38 /clang
parented74db7cd5b40f922e806331c622e223b6984311 (diff)
downloadbcm5719-llvm-39b685e4d13c4c490019f1a10ecf7f9fde7a8f89.tar.gz
bcm5719-llvm-39b685e4d13c4c490019f1a10ecf7f9fde7a8f89.zip
Make sure CodeGen uses a value of the correct type as the result of
of assignment to a bool bitfield. PR14638. llvm-svn: 170480
Diffstat (limited to 'clang')
-rw-r--r--clang/lib/CodeGen/CGExpr.cpp2
-rw-r--r--clang/test/CodeGenCXX/bool-bitfield.cpp14
2 files changed, 15 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index a36d4ee9f8d..8440eded839 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -1401,7 +1401,7 @@ void CodeGenFunction::EmitStoreThroughBitfieldLValue(RValue Src, LValue Dst,
ResultVal = Builder.CreateIntCast(ResultVal, ResLTy, Info.IsSigned,
"bf.result.cast");
- *Result = ResultVal;
+ *Result = EmitFromMemory(ResultVal, Dst.getType());
}
}
diff --git a/clang/test/CodeGenCXX/bool-bitfield.cpp b/clang/test/CodeGenCXX/bool-bitfield.cpp
new file mode 100644
index 00000000000..06bdf2bd0df
--- /dev/null
+++ b/clang/test/CodeGenCXX/bool-bitfield.cpp
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -verify -emit-llvm -o - %s \
+// RUN: | FileCheck %s
+
+// PR14638; make sure this doesn't crash.
+struct A {
+ bool m_sorted : 1;
+};
+void func1(bool b, A& a1)
+{
+ if ((a1.m_sorted = b)) {}
+}
+// CHECK: define void @_Z5func1bR1A
+// CHECK: br i1
+// CHECK: ret void
OpenPOWER on IntegriCloud