diff options
| author | Jonathan Roelofs <jonathan@codesourcery.com> | 2015-11-10 22:48:11 +0000 |
|---|---|---|
| committer | Jonathan Roelofs <jonathan@codesourcery.com> | 2015-11-10 22:48:11 +0000 |
| commit | 1ff9c632040b032c1b07679c7d8d36e0e0138d61 (patch) | |
| tree | 4336087898a757f456b660772ca0458e8f62b4e5 /clang | |
| parent | 608d67c1520b9dd960f69a9137aab1ad78daae10 (diff) | |
| download | bcm5719-llvm-1ff9c632040b032c1b07679c7d8d36e0e0138d61.tar.gz bcm5719-llvm-1ff9c632040b032c1b07679c7d8d36e0e0138d61.zip | |
Implement post-commit review feedback on r252662
llvm-svn: 252664
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/tools/scan-build/CMakeLists.txt | 13 | ||||
| -rw-r--r-- | clang/tools/scan-view/CMakeLists.txt | 5 |
2 files changed, 8 insertions, 10 deletions
diff --git a/clang/tools/scan-build/CMakeLists.txt b/clang/tools/scan-build/CMakeLists.txt index b5574dbed07..d6535a10984 100644 --- a/clang/tools/scan-build/CMakeLists.txt +++ b/clang/tools/scan-build/CMakeLists.txt @@ -13,8 +13,8 @@ else() ccc-analyzer c++-analyzer) if (APPLE) - set(BinFiles ${BinFiles} - set-xcode-analyzer) + list(APPEND BinFiles + set-xcode-analyzer) endif() endif() @@ -27,7 +27,6 @@ set(ResourceFiles if(CLANG_INSTALL_SCANBUILD) - set(Depends ) foreach(BinFile ${BinFiles}) add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/bin/${BinFile} COMMAND ${CMAKE_COMMAND} -E make_directory @@ -36,7 +35,7 @@ if(CLANG_INSTALL_SCANBUILD) ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile} ${CMAKE_BINARY_DIR}/bin/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/bin/${BinFile}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${BinFile}) install(PROGRAMS ${BinFile} DESTINATION bin) endforeach() @@ -48,7 +47,7 @@ if(CLANG_INSTALL_SCANBUILD) ${CMAKE_CURRENT_SOURCE_DIR}/${LibexecFile} ${CMAKE_BINARY_DIR}/libexec/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${LibexecFile}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/libexec/${LibexecFile}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/libexec/${LibexecFile}) install(PROGRAMS ${LibexecFile} DESTINATION libexec) endforeach() @@ -60,7 +59,7 @@ if(CLANG_INSTALL_SCANBUILD) ${CMAKE_CURRENT_SOURCE_DIR}/${ManPage} ${CMAKE_BINARY_DIR}/share/man/man1/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${ManPage}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/share/man/man1/${ManPage}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/share/man/man1/${ManPage}) install(PROGRAMS ${ManPage} DESTINATION share/man/man1) endforeach() @@ -72,7 +71,7 @@ if(CLANG_INSTALL_SCANBUILD) ${CMAKE_CURRENT_SOURCE_DIR}/${ResourceFile} ${CMAKE_BINARY_DIR}/bin/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${ResourceFile}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/bin/${ResourceFile}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${ResourceFile}) install(FILES ${ResourceFile} DESTINATION bin) endforeach() diff --git a/clang/tools/scan-view/CMakeLists.txt b/clang/tools/scan-view/CMakeLists.txt index 06840d79e94..d7561f90bd4 100644 --- a/clang/tools/scan-view/CMakeLists.txt +++ b/clang/tools/scan-view/CMakeLists.txt @@ -12,7 +12,6 @@ set(ResourceFiles bugcatcher.ico) if(CLANG_INSTALL_SCANVIEW) - set(Depends ) foreach(BinFile ${BinFiles}) add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/bin/${BinFile} COMMAND ${CMAKE_COMMAND} -E make_directory @@ -21,7 +20,7 @@ if(CLANG_INSTALL_SCANVIEW) ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile} ${CMAKE_BINARY_DIR}/bin/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/bin/${BinFile}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${BinFile}) install(PROGRAMS ${BinFile} DESTINATION bin) endforeach() @@ -33,7 +32,7 @@ if(CLANG_INSTALL_SCANVIEW) ${CMAKE_CURRENT_SOURCE_DIR}/Resources/${ResourceFile} ${CMAKE_BINARY_DIR}/share/scan-view/ DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/Resources/${ResourceFile}) - set(Depends ${Depends} ${CMAKE_BINARY_DIR}/share/scan-view/${ResourceFile}) + list(APPEND Depends ${CMAKE_BINARY_DIR}/share/scan-view/${ResourceFile}) install(FILES ${ResourceFile} DESTINATION share/scan-view) endforeach() |
