diff options
author | Amy Huang <akhuang@google.com> | 2019-10-30 17:31:12 -0700 |
---|---|---|
committer | Amy Huang <akhuang@google.com> | 2019-10-30 17:31:12 -0700 |
commit | 004ed2b0d1b86d424643ffc88fce20ad8bab6804 (patch) | |
tree | 35cf8523de716a0dd8cb975f319075f0e87324ec /clang | |
parent | 6d03890384517919a3ba7fe4c35535425f278f89 (diff) | |
download | bcm5719-llvm-004ed2b0d1b86d424643ffc88fce20ad8bab6804.tar.gz bcm5719-llvm-004ed2b0d1b86d424643ffc88fce20ad8bab6804.zip |
Revert "[CodeView] Add option to disable inline line tables."
because it breaks compiler-rt tests.
This reverts commit 6d03890384517919a3ba7fe4c35535425f278f89.
Diffstat (limited to 'clang')
-rw-r--r-- | clang/include/clang/Basic/CodeGenOptions.def | 2 | ||||
-rw-r--r-- | clang/include/clang/Driver/Options.td | 3 | ||||
-rw-r--r-- | clang/lib/CodeGen/CodeGenFunction.cpp | 4 | ||||
-rw-r--r-- | clang/lib/Driver/ToolChains/Clang.cpp | 6 | ||||
-rw-r--r-- | clang/lib/Frontend/CompilerInvocation.cpp | 1 | ||||
-rw-r--r-- | clang/test/CodeGen/debug-info-no-inline-line-tables.c | 24 |
6 files changed, 0 insertions, 40 deletions
diff --git a/clang/include/clang/Basic/CodeGenOptions.def b/clang/include/clang/Basic/CodeGenOptions.def index ebdcb3c1f48..f8d94e352f2 100644 --- a/clang/include/clang/Basic/CodeGenOptions.def +++ b/clang/include/clang/Basic/CodeGenOptions.def @@ -136,8 +136,6 @@ CODEGENOPT(FatalWarnings , 1, 0) ///< Set when -Wa,--fatal-warnings is ///< enabled. CODEGENOPT(NoWarn , 1, 0) ///< Set when -Wa,--no-warn is enabled. CODEGENOPT(EnableSegmentedStacks , 1, 0) ///< Set when -fsplit-stack is enabled. -CODEGENOPT(NoInlineLineTables, 1, 0) ///< Whether debug info should contain - ///< inline line tables. CODEGENOPT(NoImplicitFloat , 1, 0) ///< Set when -mno-implicit-float is enabled. CODEGENOPT(NoInfsFPMath , 1, 0) ///< Assume FP arguments, results not +-Inf. CODEGENOPT(NoSignedZeros , 1, 0) ///< Allow ignoring the signedness of FP zero diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 1bdeed69602..2401a31ceb9 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -1984,9 +1984,6 @@ def gcodeview_ghash : Flag<["-"], "gcodeview-ghash">, HelpText<"Emit type record hashes in a .debug$H section">, Flags<[CC1Option, CoreOption]>; def gno_codeview_ghash : Flag<["-"], "gno-codeview-ghash">, Flags<[CoreOption]>; -def ginline_line_tables : Flag<["-"], "ginline-line-tables">, Flags<[CoreOption]>; -def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">, - Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">; // Equivalent to our default dwarf version. Forces usual dwarf emission when // CodeView is enabled. diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp b/clang/lib/CodeGen/CodeGenFunction.cpp index 1b1d391a63d..3f9a52ab763 100644 --- a/clang/lib/CodeGen/CodeGenFunction.cpp +++ b/clang/lib/CodeGen/CodeGenFunction.cpp @@ -764,10 +764,6 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, Fn->addFnAttr("no-jump-tables", llvm::toStringRef(CGM.getCodeGenOpts().NoUseJumpTables)); - // Add no-inline-line-tables value. - if (CGM.getCodeGenOpts().NoInlineLineTables) - Fn->addFnAttr("no-inline-line-tables"); - // Add profile-sample-accurate value. if (CGM.getCodeGenOpts().ProfileSampleAccurate) Fn->addFnAttr("profile-sample-accurate"); diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index f5abdf15fd4..c60dc76ae1b 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -3296,12 +3296,6 @@ static void RenderDebugOptions(const ToolChain &TC, const Driver &D, } } - // Omit inline line tables if requested. - if (!Args.hasFlag(options::OPT_ginline_line_tables, - options::OPT_gno_inline_line_tables, false)) { - CmdArgs.push_back("-gno-inline-line-tables"); - } - // Adjust the debug info kind for the given toolchain. TC.adjustDebugInfoKind(DebugInfoKind, Args); diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp index 29736d2dee1..f197a67e7a3 100644 --- a/clang/lib/Frontend/CompilerInvocation.cpp +++ b/clang/lib/Frontend/CompilerInvocation.cpp @@ -806,7 +806,6 @@ static bool ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args, InputKind IK, Opts.RecordCommandLine = Args.getLastArgValue(OPT_record_command_line); Opts.MergeAllConstants = Args.hasArg(OPT_fmerge_all_constants); Opts.NoCommon = Args.hasArg(OPT_fno_common); - Opts.NoInlineLineTables = Args.hasArg(OPT_gno_inline_line_tables); Opts.NoImplicitFloat = Args.hasArg(OPT_no_implicit_float); Opts.OptimizeSize = getOptimizationLevelSize(Args); Opts.SimplifyLibCalls = !(Args.hasArg(OPT_fno_builtin) || diff --git a/clang/test/CodeGen/debug-info-no-inline-line-tables.c b/clang/test/CodeGen/debug-info-no-inline-line-tables.c deleted file mode 100644 index adf68ad90b2..00000000000 --- a/clang/test/CodeGen/debug-info-no-inline-line-tables.c +++ /dev/null @@ -1,24 +0,0 @@ -// RUN: %clang_cc1 -triple x86_64-windows-msvc -debug-info-kind=limited \ -// RUN: -gno-inline-line-tables -emit-llvm -o - %s | FileCheck %s - -int x; -__attribute((always_inline)) void f() { - x += 1; -} -int main() { - f(); - x += 2; - return x; -} - -// Check that clang emits the location of the call site and not the inlined -// function in the debug info. -// CHECK: define dso_local i32 @main() -// CHECK: %{{.+}} = load i32, i32* @x, align 4, !dbg [[DbgLoc:![0-9]+]] - -// Check that the no-inline-line-tables attribute is added. -// CHECK: attributes #0 = {{.*}}"no-inline-line-tables"{{.*}} -// CHECK: attributes #1 = {{.*}}"no-inline-line-tables"{{.*}} - -// CHECK: [[DbgLoc]] = !DILocation(line: 9, -// CHECK-NOT: inlinedAt: |