summaryrefslogtreecommitdiffstats
path: root/clang/unittests/Tooling/SourceCodeTest.cpp
diff options
context:
space:
mode:
authorJulian Lettner <jlettner@apple.com>2019-10-10 00:33:04 +0000
committerJulian Lettner <jlettner@apple.com>2019-10-10 00:33:04 +0000
commitb577efe4567f1f6a711ad36e1d17280dd1c4f009 (patch)
treedb99143a2af9841c57ec159ee2e0ef5dda26869a /clang/unittests/Tooling/SourceCodeTest.cpp
parentd6e9e99cec95c83293c68d3b30534e34f53a1923 (diff)
downloadbcm5719-llvm-b577efe4567f1f6a711ad36e1d17280dd1c4f009.tar.gz
bcm5719-llvm-b577efe4567f1f6a711ad36e1d17280dd1c4f009.zip
[ASan] Do not misrepresent high value address dereferences as null dereferences
Dereferences with addresses above the 48-bit hardware addressable range produce "invalid instruction" (instead of "invalid access") hardware exceptions (there is no hardware address decoding logic for those bits), and the address provided by this exception is the address of the instruction (not the faulting address). The kernel maps the "invalid instruction" to SEGV, but fails to provide the real fault address. Because of this ASan lies and says that those cases are null dereferences. This downgrades the severity of a found bug in terms of security. In the ASan signal handler, we can not provide the real faulting address, but at least we can try not to lie. rdar://50366151 Reviewed By: vitalybuka Differential Revision: https://reviews.llvm.org/D68676 llvm-svn: 374265
Diffstat (limited to 'clang/unittests/Tooling/SourceCodeTest.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud