diff options
author | Krasimir Georgiev <krasimir@google.com> | 2018-05-23 14:18:19 +0000 |
---|---|---|
committer | Krasimir Georgiev <krasimir@google.com> | 2018-05-23 14:18:19 +0000 |
commit | 0fb19de0c3ac9057d44ac5a3bbfa9d0d332dfb8c (patch) | |
tree | 6ba38740b8d4302384f15db6f499e94ea82f942c /clang/unittests/Format/FormatTest.cpp | |
parent | 5c4fb4566d766d029c73b611feab55c67662b332 (diff) | |
download | bcm5719-llvm-0fb19de0c3ac9057d44ac5a3bbfa9d0d332dfb8c.tar.gz bcm5719-llvm-0fb19de0c3ac9057d44ac5a3bbfa9d0d332dfb8c.zip |
[clang-format] Break template declarations followed by comments
Summary:
This patch fixes two bugs in clang-format where the template wrapper doesn't skip over
comments causing a long template declaration to not be split into multiple lines.
These were latent and exposed by r332436.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D47257
llvm-svn: 333085
Diffstat (limited to 'clang/unittests/Format/FormatTest.cpp')
-rw-r--r-- | clang/unittests/Format/FormatTest.cpp | 52 |
1 files changed, 52 insertions, 0 deletions
diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp index 624b086a216..87e88200bb9 100644 --- a/clang/unittests/Format/FormatTest.cpp +++ b/clang/unittests/Format/FormatTest.cpp @@ -5521,6 +5521,58 @@ TEST_F(FormatTest, WrapsTemplateDeclarations) { NeverBreak); } +TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { + FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); + Style.ColumnLimit = 60; + EXPECT_EQ(R"test( +// Baseline - no comments. +template < + typename aaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbbb>::value> +void f() {})test", + format(R"test( +// Baseline - no comments. +template < + typename aaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbbb>::value> +void f() {})test", Style)); + + EXPECT_EQ(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing +void f() {})test", + format(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing +void f() {})test", Style)); + + EXPECT_EQ(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> /* line */ +void f() {})test", + format(R"test( +template <typename aaaaaaaaaa<bbbbbbbbbbbb>::value> /* line */ +void f() {})test", Style)); + + EXPECT_EQ(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing + // multiline +void f() {})test", + format(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing + // multiline +void f() {})test", Style)); + + EXPECT_EQ(R"test( +template <typename aaaaaaaaaa< + bbbbbbbbbbbb>::value> // trailing loooong +void f() {})test", + format(R"test( +template < + typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing loooong +void f() {})test", Style)); +} + TEST_F(FormatTest, WrapsTemplateParameters) { FormatStyle Style = getLLVMStyle(); Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; |