diff options
| author | Alp Toker <alp@nuanti.com> | 2014-04-26 14:43:53 +0000 |
|---|---|---|
| committer | Alp Toker <alp@nuanti.com> | 2014-04-26 14:43:53 +0000 |
| commit | 87d3975369899137f61d1f1574da263db10dd566 (patch) | |
| tree | 81930b3a4683e10503a8e40f206f6f6ae1d86987 /clang/tools/libclang/CXLoadedDiagnostic.cpp | |
| parent | 6d2dff61f9fd71248911d53ed0e1b7bfb3f9d012 (diff) | |
| download | bcm5719-llvm-87d3975369899137f61d1f1574da263db10dd566.tar.gz bcm5719-llvm-87d3975369899137f61d1f1574da263db10dd566.zip | |
libclang: remove 'CXDiagnostic_Remark'
The change was landed without review or test cases.
It trivially broke almost any stable application checking for Severity >=
CXDiagnostic_Error or indeed any other kind of severity comparison upon
encountering a 'remark'.
Mapped to CXDiagnostic_Warning until a workable solution is proposed to the
list that preserves API stability.
(It's also not clear why the rest of r202475 wasn't simply implemented as a
modifier to the existing 'warning' level.)
llvm-svn: 207319
Diffstat (limited to 'clang/tools/libclang/CXLoadedDiagnostic.cpp')
| -rw-r--r-- | clang/tools/libclang/CXLoadedDiagnostic.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/tools/libclang/CXLoadedDiagnostic.cpp b/clang/tools/libclang/CXLoadedDiagnostic.cpp index 679c5285263..8385f242d44 100644 --- a/clang/tools/libclang/CXLoadedDiagnostic.cpp +++ b/clang/tools/libclang/CXLoadedDiagnostic.cpp @@ -79,8 +79,9 @@ CXDiagnosticSeverity CXLoadedDiagnostic::getSeverity() const { CASE(Warning) CASE(Error) CASE(Fatal) - CASE(Remark) #undef CASE + // The 'Remark' level isn't represented in the stable API. + case serialized_diags::Remark: return CXDiagnostic_Warning; } llvm_unreachable("Invalid diagnostic level"); |
