diff options
author | Daniel Jasper <djasper@google.com> | 2013-07-02 13:20:35 +0000 |
---|---|---|
committer | Daniel Jasper <djasper@google.com> | 2013-07-02 13:20:35 +0000 |
commit | a3fc21a0f1b89d59207b10ef7c4438ad1d4ced8b (patch) | |
tree | 18ef40ee19ae061efc83078a401b2ea9022d082e /clang/tools/clang-format/git-clang-format | |
parent | c931fce4042097671188bbd6b8064e2be5b1e3f5 (diff) | |
download | bcm5719-llvm-a3fc21a0f1b89d59207b10ef7c4438ad1d4ced8b.tar.gz bcm5719-llvm-a3fc21a0f1b89d59207b10ef7c4438ad1d4ced8b.zip |
Fix ranges computed by git clang-format.
Before, the computed byte range would include the trailing newline.
clang-format on the other hand counts whitespace as belonging to the
following token, so that git-clang-format inadvertendly reformats the
first unmodified line as well.
It is not entirely clear whether clang-format's behavior itself should
be modified, but for now this seems to be a safe change.
llvm-svn: 185423
Diffstat (limited to 'clang/tools/clang-format/git-clang-format')
-rwxr-xr-x | clang/tools/clang-format/git-clang-format | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/tools/clang-format/git-clang-format b/clang/tools/clang-format/git-clang-format index 62fe67c19ed..763fc35aae2 100755 --- a/clang/tools/clang-format/git-clang-format +++ b/clang/tools/clang-format/git-clang-format @@ -329,13 +329,13 @@ def lines_to_bytes_single_file(file, line_ranges): if linenum == r.start: byte_start = byte_idx if linenum == r.start + r.count: - byte_ranges.append(Range(byte_start, byte_idx - byte_start)) + byte_ranges.append(Range(byte_start, byte_idx - byte_start - 1)) r = next(line_ranges_iter) linenum += 1 byte_idx += len(line) if r is not None: # FIXME: Detect and warn if line ranges go past the end of file? - byte_ranges.append(Range(byte_start, byte_idx - byte_start)) + byte_ranges.append(Range(byte_start, byte_idx - byte_start - 1)) return byte_ranges |