diff options
| author | Fangrui Song <maskray@google.com> | 2018-12-12 08:02:18 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2018-12-12 08:02:18 +0000 |
| commit | 5313327f61cc6524f99639cf792db41285615558 (patch) | |
| tree | be1daf981a3aa7866bc61ff53df06e253526ecca /clang/tools/clang-check | |
| parent | 9098a8b5eff0f524a922c21ef4f35aec8f416091 (diff) | |
| download | bcm5719-llvm-5313327f61cc6524f99639cf792db41285615558.tar.gz bcm5719-llvm-5313327f61cc6524f99639cf792db41285615558.zip | |
Add explicit dependency on clangSerialization for a bunch of components to fix -DBUILD_SHARED_LIBS=on build
This is a more thorough fix of rC348911.
The story about -DBUILD_SHARED_LIBS=on build after rC348907 (Move PCHContainerOperations from Frontend to Serialization) is:
1. libclangSerialization.so defines PCHContainerReader dtor, ...
2. clangFrontend and clangTooling define classes inheriting from PCHContainerReader, thus their DSOs have undefined references on PCHContainerReader dtor
3. Components depending on either clangFrontend or clangTooling cannot be linked unless they have explicit dependency on clangSerialization due to the default linker option -z defs. The explicit dependency could be avoided if libclang{Frontend,Tooling}.so had these undefined references.
This patch adds the explicit dependency on clangSerialization to make them build.
llvm-svn: 348915
Diffstat (limited to 'clang/tools/clang-check')
| -rw-r--r-- | clang/tools/clang-check/CMakeLists.txt | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/clang/tools/clang-check/CMakeLists.txt b/clang/tools/clang-check/CMakeLists.txt index c5ace26c291..b837b0a0a5d 100644 --- a/clang/tools/clang-check/CMakeLists.txt +++ b/clang/tools/clang-check/CMakeLists.txt @@ -15,6 +15,7 @@ target_link_libraries(clang-check clangDriver clangFrontend clangRewriteFrontend + clangSerialization clangStaticAnalyzerFrontend clangTooling ) |
