patch to suggest 'static' function should be 'static inline'

when it appears to be unused and occurs in a header.
// rdar://11202617

llvm-svn: 159282

2 files changed, 15 insertions, 0 deletions

diff --git a/clang/test/SemaCXX/warn-static-function-inheader.cpp b/clang/test/SemaCXX/warn-static-function-inheader.cpp
new file mode 100644
index 00000000000..30386d9a258
--- /dev/null
+++ b/clang/test/SemaCXX/warn-static-function-inheader.cpp
@@ -0,0 +1,12 @@
+#include "warn-static-function-inheader.h"
+// RUN: %clang_cc1 -fsyntax-only -verify -Wall %s
+// rdar://11202617
+
+static void another(void) { // expected-warning {{function 'another' is not needed and will not be emitted}}
+}
+
+template <typename T>
+void foo(void) {
+        thing();
+	another();
+}
diff --git a/clang/test/SemaCXX/warn-static-function-inheader.h b/clang/test/SemaCXX/warn-static-function-inheader.h
new file mode 100644
index 00000000000..1c9e00b8bd2
--- /dev/null
+++ b/clang/test/SemaCXX/warn-static-function-inheader.h
@@ -0,0 +1,3 @@
+static void thing(void) { // expected-warning {{'static' function 'thing' declared in header file should be declared 'static inline'}}
+}
+