diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2015-01-19 09:00:28 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2015-01-19 09:00:28 +0000 |
| commit | 2dc8146643856d29c33880b86506141d30d5866f (patch) | |
| tree | 6480c97086c09f0160678b9284effd8ea01c864c /clang/test | |
| parent | 0540f4141fb187d6f5cb2d871bd5fbc27e1f4512 (diff) | |
| download | bcm5719-llvm-2dc8146643856d29c33880b86506141d30d5866f.tar.gz bcm5719-llvm-2dc8146643856d29c33880b86506141d30d5866f.zip | |
Sema: Variable definitions cannot be __attribute__((alias))
Things that are OK:
extern int var1 __attribute((alias("v1")));
static int var2 __attribute((alias("v2")));
Things that are not OK:
int var3 __attribute((alias("v3")));
extern int var4 __attribute((alias("v4"))) = 4;
We choose to accpet:
struct S { static int var5 __attribute((alias("v5"))); };
This code causes assertion failues in GCC 4.8 and ICC 13.0.1, we have
no reason to reject it.
This partially fixes PR22217.
llvm-svn: 226436
Diffstat (limited to 'clang/test')
| -rw-r--r-- | clang/test/Misc/ast-dump-attr.cpp | 2 | ||||
| -rw-r--r-- | clang/test/Sema/alias-redefinition.c | 21 |
2 files changed, 3 insertions, 20 deletions
diff --git a/clang/test/Misc/ast-dump-attr.cpp b/clang/test/Misc/ast-dump-attr.cpp index 446f0fa692f..ed6d1f5781d 100644 --- a/clang/test/Misc/ast-dump-attr.cpp +++ b/clang/test/Misc/ast-dump-attr.cpp @@ -79,7 +79,7 @@ void TestInt(void) __attribute__((constructor(123))); // CHECK: FunctionDecl{{.*}}TestInt // CHECK-NEXT: ConstructorAttr{{.*}} 123 -int TestString __attribute__((alias("alias1"))); +static int TestString __attribute__((alias("alias1"))); // CHECK: VarDecl{{.*}}TestString // CHECK-NEXT: AliasAttr{{.*}} "alias1" diff --git a/clang/test/Sema/alias-redefinition.c b/clang/test/Sema/alias-redefinition.c index 6c6ebf80250..9f9930dc2a9 100644 --- a/clang/test/Sema/alias-redefinition.c +++ b/clang/test/Sema/alias-redefinition.c @@ -23,22 +23,5 @@ void fun4(void); void f5() {} void __attribute((alias("f5"))) fun5(void) {} // expected-error {{redefinition of 'fun5'}} // expected-note {{previous definition}} -int v1; -int var1 __attribute((alias("v1"))); // expected-note {{previous definition}} -int var1 __attribute((alias("v1"))); // expected-error {{redefinition of 'var1'}} - -int v2; -int var2 = 2; // expected-note {{previous definition}} -int var2 __attribute((alias("v2"))); // expected-error {{redefinition of 'var2'}} - -int v3; -int var3 __attribute((alias("v3"))); // expected-note {{previous definition}} -int var3 = 2; // expected-error {{redefinition of 'var3'}} - -int v4; -int var4; // expected-note {{previous definition}} -int var4 __attribute((alias("v4"))); // expected-error {{alias definition of 'var4' after tentative definition}} - -int v5; -int var5 __attribute((alias("v5"))); // expected-note {{previous definition}} -int var5; // expected-error {{tentative definition of 'var5' after alias definition}} +int var1 __attribute((alias("v1"))); // expected-error {{definition 'var1' cannot also be an alias}} +static int var2 __attribute((alias("v2"))) = 2; // expected-error {{definition 'var2' cannot also be an alias}} |
