Reduce -Wuninitialized time by 22% (on sqlite) by removing the recursive AST crawl.

This is accomplished by forcing the needed expressions for -Wuninitialized to always be CFGElements in the CFG.
This allows us to remove a fair amount of the code for -Wuninitialized.

Some fallout:
- AnalysisBasedWarnings.cpp now specifically toggles the CFGBuilder to create a CFG that is suitable for -Wuninitialized.  This
is a layering violation, since the logic for -Wuninitialized is in libAnalysis.  This can be fixed with the proper refactoring.
- Some of the source locations for -Wunreachable-code warnings have shifted.  While not ideal, this is okay because that analysis
already needs some serious reworking.

llvm-svn: 135480

1 files changed, 4 insertions, 4 deletions

diff --git a/clang/test/SemaCXX/warn-unreachable.cpp b/clang/test/SemaCXX/warn-unreachable.cpp
index ea6755f2d6c..604a3c0da38 100644
--- a/clang/test/SemaCXX/warn-unreachable.cpp
+++ b/clang/test/SemaCXX/warn-unreachable.cpp
@@ -45,8 +45,8 @@ void test3() {
     ? 
     dead() : dead();
   live(),
-    float       // expected-warning {{will never be executed}}
-      (halt());
+    float       
+      (halt()); // expected-warning {{will never be executed}}
 }
 
 void test4() {
@@ -73,6 +73,6 @@ void test6() {
     S(int i) { }
   };
   live(),
-    S            // expected-warning {{will never be executed}}
-      (halt());
+    S
+      (halt());  // expected-warning {{will never be executed}}
 }