diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2013-03-29 21:43:21 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2013-03-29 21:43:21 +0000 |
| commit | 054faa5a4883c1a216f1edce62eb464913b33213 (patch) | |
| tree | 1f6044cc592d8f633ce43d625535ed65e1bcd508 /clang/test/Sema/expr-comma.c | |
| parent | cf1dc8d39e2c9870468ca86f7956a65c7745fece (diff) | |
| download | bcm5719-llvm-054faa5a4883c1a216f1edce62eb464913b33213.tar.gz bcm5719-llvm-054faa5a4883c1a216f1edce62eb464913b33213.zip | |
Sema: Warn on sizeof on binary ops on decayed arrays.
The array will decay into a pointer, creating an unexpected result.
sizeof(array + int) is an easy to make typo for sizeof(array) + int.
This was motivated by a NetBSD security bug, used sizeof(key - r) instead of
sizeof(key) - r, reducing entropy in a random number generator.
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/kern/subr_cprng.c.diff?r1=1.14&r2=1.15&only_with_tag=MAIN&f=h
Differential Revision: http://llvm-reviews.chandlerc.com/D571
llvm-svn: 178371
Diffstat (limited to 'clang/test/Sema/expr-comma.c')
| -rw-r--r-- | clang/test/Sema/expr-comma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/test/Sema/expr-comma.c b/clang/test/Sema/expr-comma.c index 7902715915a..e2beafe236c 100644 --- a/clang/test/Sema/expr-comma.c +++ b/clang/test/Sema/expr-comma.c @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 %s -fsyntax-only -verify -std=c89 +// RUN: %clang_cc1 %s -fsyntax-only -verify -std=c89 -Wno-sizeof-array-decay // expected-no-diagnostics // rdar://6095180 |
