diff options
| author | Jakub Kuderski <kubakuderski@gmail.com> | 2018-02-12 23:37:27 +0000 |
|---|---|---|
| committer | Jakub Kuderski <kubakuderski@gmail.com> | 2018-02-12 23:37:27 +0000 |
| commit | 6780557bfc8c257b45a0c50ca1d51f9247f4123f (patch) | |
| tree | 12d198e4bf88569354395327406a54f005f12783 /clang/test/Preprocessor/assembler-with-cpp.c | |
| parent | de3e889a88932524072e1e934d0f30b79c351d3a (diff) | |
| download | bcm5719-llvm-6780557bfc8c257b45a0c50ca1d51f9247f4123f.tar.gz bcm5719-llvm-6780557bfc8c257b45a0c50ca1d51f9247f4123f.zip | |
[Dominators] Always recalculate postdominators when update yields different roots
Summary:
This patch makes postdominators always recalculate the tree when an update causes to change the tree roots.
As @dmgreen noticed in [[ https://reviews.llvm.org/D41298 | D41298 ]], the previous implementation was not conservative enough and it was possible to end up with a PostDomTree that was different than a freshly computed one.
The patch also compares postdominators with a freshly computed tree at the end of full verification to make sure we don't hit similar issues in the future.
This should (ideally) be also backported to 6.0 before the release, although I don't have any reports of this causing an observable error. It should be safe to do it even if it's late in the release, as the change only makes the current behavior more conservative.
Reviewers: dmgreen, dberlin, davide, brzycki, grosser
Reviewed By: brzycki, grosser
Subscribers: llvm-commits, dmgreen
Differential Revision: https://reviews.llvm.org/D43140
llvm-svn: 324962
Diffstat (limited to 'clang/test/Preprocessor/assembler-with-cpp.c')
0 files changed, 0 insertions, 0 deletions
