diff options
| author | Adrian McCarthy <amccarth@google.com> | 2019-11-07 10:50:33 -0800 |
|---|---|---|
| committer | Adrian McCarthy <amccarth@google.com> | 2019-11-14 08:48:47 -0800 |
| commit | 1275ab1620b665eb06231ce3c4e5068c97d9b618 (patch) | |
| tree | 64bca2aef09e015a26b9dbbb58046982b415b721 /clang/test/Modules | |
| parent | bbcbb10e2d0848b611c51b1ff56c758645c55f3b (diff) | |
| download | bcm5719-llvm-1275ab1620b665eb06231ce3c4e5068c97d9b618.tar.gz bcm5719-llvm-1275ab1620b665eb06231ce3c4e5068c97d9b618.zip | |
Improve VFS compatibility on Windows
Keys in a virtual file system can be in Posix or Windows form or even
a combination of the two. Many VFS tests (and a few Clang tests) were
XFAILed on Windows because of false negatives when comparing paths.
First, we default CaseSenstive to false on Windows. This allows
drive letters like "D:" to match "d:". Windows filesystems are, by
default, case insensitive, so this makes sense even beyond the drive
letter.
Second, we allow slashes to match backslashes when they're used as the
root component of a path.
Both of these changes are limited to RedirectingFileSystems, so there's
little chance of affecting other path handling.
These changes allow eleven of the VFS tests to pass on Windows as well
as three other Clang tests, so they have re-enabled.
This solves the majority of PR43272. Additional VFS test failures will
be fixed in separate patches.
Differential Revision: https://reviews.llvm.org/D69958
Diffstat (limited to 'clang/test/Modules')
| -rw-r--r-- | clang/test/Modules/double-quotes.m | 3 | ||||
| -rw-r--r-- | clang/test/Modules/framework-public-includes-private.m | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/clang/test/Modules/double-quotes.m b/clang/test/Modules/double-quotes.m index bed6a48726b..4ce712ccc6c 100644 --- a/clang/test/Modules/double-quotes.m +++ b/clang/test/Modules/double-quotes.m @@ -1,6 +1,3 @@ -// FIXME: PR43272 -// XFAIL: system-windows - // RUN: rm -rf %t // RUN: mkdir %t diff --git a/clang/test/Modules/framework-public-includes-private.m b/clang/test/Modules/framework-public-includes-private.m index be9223016ba..0f1e3a242a1 100644 --- a/clang/test/Modules/framework-public-includes-private.m +++ b/clang/test/Modules/framework-public-includes-private.m @@ -1,6 +1,3 @@ -// FIXME: PR43272 -// XFAIL: system-windows - // RUN: rm -rf %t // RUN: mkdir %t |
