diff options
author | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-06-08 11:15:09 +0000 |
---|---|---|
committer | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-06-08 11:15:09 +0000 |
commit | 1425b477735e5cb826e5be1e23deee31ad5fbd97 (patch) | |
tree | 0bbd3645241ed7dee138e8e8eb3b5d9b7b1a429f /clang/test/CodeGenCXX/stack-reuse-miscompile.cpp | |
parent | 8a7b827b3decdc63e1c390080a0e46ac0eb7773d (diff) | |
download | bcm5719-llvm-1425b477735e5cb826e5be1e23deee31ad5fbd97.tar.gz bcm5719-llvm-1425b477735e5cb826e5be1e23deee31ad5fbd97.zip |
[LLDB-MI] Properly detect missing mandatory arguments to MI commands
Summary:
Previously if an MI command had **X** mandatory and **Y** optional arguments you could provide **X** or more optional arguments without providing any of the mandatory arguments, and the argument validation code wouldn't complain.
For example this would pass argument validation even though the mandatory **address** and **count** arguments are missing:
-data-read-memory-bytes --thread 1 --frame 0
Part of the problem was that an empty string was considered a valid value for a mandatory argument, which didn't make much sense.
Patch by Vadim Macagon. Thanks!
Test Plan:
./dotest.py -A x86_64 -C clang --executable $BUILDDIR/bin/lldb tools/lldb-mi/
No unexpected failures on my Ubuntu 14.10 64bit Virtualbox VM.
Reviewers: domipheus, ki.stfu, abidh
Reviewed By: ki.stfu, abidh
Subscribers: brucem, lldb-commits
Differential Revision: http://reviews.llvm.org/D10299
llvm-svn: 239297
Diffstat (limited to 'clang/test/CodeGenCXX/stack-reuse-miscompile.cpp')
0 files changed, 0 insertions, 0 deletions